Étiquettes Jalons

conversion to cmake #2

Fusionnée

SlavekB a fusionné 1 révision(s) à partir de feat/cmakeConv vers master il y a 6 ans

Discussion 2 Révisions 1 Fichiers Modifiés 14

Ghost a commenté il y a 6 ans

I've added a man page taken from your Debian repo.

I've changed the name KDE into TDE in folder ../HTML/index.html.

I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.

I've added a man page taken from your Debian repo. I've changed the name KDE into TDE in folder ../HTML/index.html. I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.

SlavekB a commenté il y a 6 ans

Propriétaire

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15.

During that, I noticed a code that seems to me wrong. look at krename/krenameimpl.cpp#L1174 - I believe that there is an endless loop, because d is initiated as '/' and the other parts are added during loop => can never be met !d->isEmpty().

Am I wrong, or am I right?

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15. During that, I noticed a code that seems to me wrong. look at [krename/krenameimpl.cpp#L1174](src/branch/master/krename/krenameimpl.cpp#L1174) - I believe that there is an endless loop, because `d` is initiated as `'/'` and the other parts are added during loop => can never be met `!d->isEmpty()`. Am I wrong, or am I right?

SlavekB a fermé cette pull request il y a 6 ans

SlavekB a supprimé la branche feat/cmakeConv il y a 6 ans

SlavekB a ajouté cela au jalon R14.0.6 release il y a 6 ans

SlavekB a commenté il y a 6 ans

Propriétaire

The endless loop will be solved in a separate commit.

The endless loop will be solved in a separate commit.

La demande d'ajout a été fusionnée en e023691c15.

Connectez-vous pour rejoindre cette conversation.

Relecteurs

Demander une revue

Aucune évaluation

Étiquettes

Appliquer une étiquette

Effacer les étiquettes

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

Pas d'étiquette GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Jalon

Affecter un jalon

Effacer le jalon

Pas d'élément

Aucun jalon

R14.0.6 release

Affecté à

Assigner des utilisateurs

Supprimer les affectations

Pas d'assignataires

2 participants

Notifications

S’abonner

Échéance

La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Reference: TDE/krename#2

Écrire Aperçu

Chargement…

Annuler

Enregistrer

Il n'existe pas encore de contenu.