TDE
/
krename
6
0
포크 0
코드 이슈 풀 리퀘스트 릴리즈 위키 활동
레이블 마일스톤

conversion to cmake #2

병합
SlavekB feat/cmakeConv 에서 master 로 1 commits 를 머지했습니다 6 년 전
대화 2 커밋 1 파일 변경됨 14
Ghost 코멘트됨, 6 년 전

I've added a man page taken from your Debian repo.

I've changed the name KDE into TDE in folder ../HTML/index.html.

I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.

I've added a man page taken from your Debian repo. I've changed the name KDE into TDE in folder ../HTML/index.html. I've changed the files zh_CN.GB2312.po into zh_CN.po and zh_TW.Big5.po into zh_TW.po.
SlavekB 코멘트됨, 6 년 전
소유자

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15.

During that, I noticed a code that seems to me wrong. look at krename/krenameimpl.cpp#L1174 - I believe that there is an endless loop, because d is initiated as '/' and the other parts are added during loop => can never be met !d->isEmpty().

Am I wrong, or am I right?

I have solved the ascii cast, useless use of TQString over i18n and several deprecated NetAccess methods in e023691c15. During that, I noticed a code that seems to me wrong. look at [krename/krenameimpl.cpp#L1174](src/branch/master/krename/krenameimpl.cpp#L1174) - I believe that there is an endless loop, because `d` is initiated as `'/'` and the other parts are added during loop => can never be met `!d->isEmpty()`. Am I wrong, or am I right?
SlavekB closed this pull request 6 년 전
SlavekB 삭제된 브랜치 feat/cmakeConv 6 년 전
SlavekB R14.0.6 release 6 년 전 마일스톤을 추가하였습니다.
SlavekB 코멘트됨, 6 년 전
소유자

The endless loop will be solved in a separate commit.

The endless loop will be solved in a separate commit.
The pull request has been merged as e023691c15.
로그인하여 이 대화에 참여
리뷰어
Request review
No reviewers
레이블
Apply labels
레이블 초기화
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
레이블 없음 GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
마일스톤
Set milestone
마일스톤 초기화
No items
마일스톤 없음
R14.0.6 release
담당자
Assign users
담당자 초기화
담당자 없음
참여자 2명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/krename#2
쓰기 미리보기
불러오는 중...
취소
저장
아직 콘텐츠가 없습니다.
'feat/cmakeConv' 브랜치 삭제

Deleting a branch is permanent. It CANNOT be undone. Continue?

아니오
예