Confusing use of variable addCmd in arc_vfs code #4

Open
opened 6 years ago by SlavekB · 0 comments
Owner

From Antonio Diaz Diaz

The following is not a bug, but it is confusing.
At line 91 of 'krusader/VFS/arc_vfs.h' we find:

   TQString cmd;      // the archiver main command
   TQString listCmd;  // the file listing option
   TQString delCmd;   // the delete option
   TQString addCmd;   // the add files option
   TQString getCmd;   // the extract files option

But then in 'krusader/VFS/arc_vfs.cpp', 'addCmd' is set to a full
command + option:

     cmd = KrServices::fullPathName ( "gzip" );
     listCmd = "-l";
     delCmd  = "";
     addCmd  = KrServices::fullPathName ( "gzip" ) + " -c";
     getCmd  = "-dc";
**From Antonio Diaz Diaz** The following is not a bug, but it is confusing. At line 91 of 'krusader/VFS/arc_vfs.h' we find: ``` TQString cmd; // the archiver main command TQString listCmd; // the file listing option TQString delCmd; // the delete option TQString addCmd; // the add files option TQString getCmd; // the extract files option ``` But then in 'krusader/VFS/arc_vfs.cpp', 'addCmd' is set to a full command + option: ``` cmd = KrServices::fullPathName ( "gzip" ); listCmd = "-l"; delCmd = ""; addCmd = KrServices::fullPathName ( "gzip" ) + " -c"; getCmd = "-dc"; ```
SlavekB added the SL/minor label 6 years ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/krusader#4
Loading…
There is no content yet.