conversion to cmake building system #1

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 6 years ago
Ghost commented 6 years ago

I've added the man page from your debian packaging folder.

It seems that Ksensors may profit from hddtemp (hddtemp 0.3-beta15-52) to display the hard disk temperature,
but if I'm not mistaken Debian is not build with It.

5 files refer to SENSORS_API_VERSION 0x400 (which I believe is lm-sensors 3.0 and up).
I think the code (SENSORS_API_VERSION < 0x400) can be removed.

-UTQT_NO_ASCII_CAST is needed to build otherwise I get this error:

ksensors/src/hdsensorslist.cpp: In constructor 'HDSensorsList::HDSensorsList(TQObject*, const char*)':
ksensors/src/hdsensorslist.cpp:57:27: error: no matching function for call to 'Sensor::setName(TQString&)'
        sensor->setName(*it);
                           ^
ksensors/src/sensor.h:21:0,
ksensors/src/hdsensorslist.cpp:28:
/usr/include/tqt3/ntqobject.h:99:18: note: candidate: virtual void TQObject::setName(const char*)
     virtual void setName( const char *name );
                  ^
/usr/include/tqt3/ntqobject.h:99:18: note:   no known conversion for argument 1 from 'TQString' to 'const char*'

-UTQT_NO_COMPAT is needed to build otherwise I get this error:

ksensors/build/src/lmsensorscfgdesign.cpp: In constructor 'LMSensorsCfgDesign::LMSensorsCfgDesign(TQWidget*, const char*, TQt::WFlags)':
ksensors/build/src/lmsensorscfgdesign.cpp:258:22: error: 'class TQCheckBox' has no member named 'setAutoResize'
     CheckAllSensors->setAutoResize( TRUE );
                      ^

lmsensorscfgdesign.cpp is generated at compile time from lmsensorscfgdesign.ui
TQCheckBox inherits from TQButton but is not available unless I pass UTQT_NO_COMPAT

Line 200 in ntqbutton.h

I've added the man page from your debian packaging folder. It seems that Ksensors may profit from hddtemp (hddtemp 0.3-beta15-52) to display the hard disk temperature, but if I'm not mistaken Debian is not build with It. 5 files refer to SENSORS_API_VERSION 0x400 (which I believe is lm-sensors 3.0 and up). I think the code (SENSORS_API_VERSION < 0x400) can be removed. -UTQT_NO_ASCII_CAST is needed to build otherwise I get this error: ``` ksensors/src/hdsensorslist.cpp: In constructor 'HDSensorsList::HDSensorsList(TQObject*, const char*)': ksensors/src/hdsensorslist.cpp:57:27: error: no matching function for call to 'Sensor::setName(TQString&)' sensor->setName(*it); ^ ksensors/src/sensor.h:21:0, ksensors/src/hdsensorslist.cpp:28: /usr/include/tqt3/ntqobject.h:99:18: note: candidate: virtual void TQObject::setName(const char*) virtual void setName( const char *name ); ^ /usr/include/tqt3/ntqobject.h:99:18: note: no known conversion for argument 1 from 'TQString' to 'const char*' ``` -UTQT_NO_COMPAT is needed to build otherwise I get this error: ``` ksensors/build/src/lmsensorscfgdesign.cpp: In constructor 'LMSensorsCfgDesign::LMSensorsCfgDesign(TQWidget*, const char*, TQt::WFlags)': ksensors/build/src/lmsensorscfgdesign.cpp:258:22: error: 'class TQCheckBox' has no member named 'setAutoResize' CheckAllSensors->setAutoResize( TRUE ); ^ ``` lmsensorscfgdesign.cpp is generated at compile time from lmsensorscfgdesign.ui TQCheckBox inherits from TQButton but is not available unless I pass UTQT_NO_COMPAT Line 200 in ntqbutton.h
Owner

Small cleaning is done in the application icon installation code.

Added controlled conversions to char* instead of automatic ascii conversions, -UTQT_NO_ASCII_CAST is no longer needed.

The need for -UTQT_NO_COMPAT remains for now.

Small cleaning is done in the application icon installation code. Added controlled conversions to `char*` instead of automatic ascii conversions, `-UTQT_NO_ASCII_CAST` is no longer needed. The need for `-UTQT_NO_COMPAT` remains for now.
Owner

I tried to test whether autoResize on the CheckAllSensors check box is still needed and I did not notice any difference in GUI when I removed it.

Please test the last patch.

I tried to test whether `autoResize` on the `CheckAllSensors` check box is still needed and I did not notice any difference in GUI when I removed it. Please test the last patch.
Ghost commented 6 years ago
Poster

Will test in the afternoon.

Will test in the afternoon.
Ghost commented 6 years ago
Poster

I didn't see much changes either.

I installed two ksensors apps, one in /usr one in /opt; unfortunately It doesn't seem possible to run both at the same time.

I played/clicked a bit everywhere, including with the specific parameters for the window (only the case box "size", not the others parameters), resizing the panels at will in the main window and the two apps seem to work in the same manner.

Do you know exactly which group of buttons that property is supposed to set (on the ui not in the code)?

I didn't see much changes either. I installed two ksensors apps, one in /usr one in /opt; unfortunately It doesn't seem possible to run both at the same time. I played/clicked a bit everywhere, including with the specific parameters for the window (only the case box "size", not the others parameters), resizing the panels at will in the main window and the two apps seem to work in the same manner. Do you know exactly which group of buttons that property is supposed to set (on the ui not in the code)?
Owner

According to the source code, it should be check box named Apply to all sensors on the Alarms tab in the sensors settings - bellow in the group named On reach alarm value:.

According to the source code, it should be check box named Apply to all sensors on the Alarms tab in the sensors settings - bellow in the group named On reach alarm value:.
SlavekB closed this pull request 6 years ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB deleted branch feat/cmakeConv 6 years ago
SlavekB added this to the R14.0.6 release milestone 6 years ago
The pull request has been merged as 5f63794da4.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/ksensors#1
Loading…
There is no content yet.