cmake conversion #1

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 5 years ago
Ghost commented 5 years ago

I've added a man page taken from your Debian packaging system.

I've added a man page taken from your Debian packaging system.
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

Please, give attention to my comments below. For now, I did not test it but it looks good.

Please, give attention to my comments below. For now, I did not test it but it looks good.
include(TestBigEndian)
test_big_endian(WORDS_BIGENDIAN)
Owner

Please add here as another standard test:

tde_setup_largefiles( )
Please add here as another standard test: ``` tde_setup_largefiles( ) ```
set( __KDE_HAVE_GCC_VISIBILITY 1 )
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
endif( WITH_GCC_VISIBILITY )
Owner

Please use a new common test:

tde_setup_gcc_visibility( )
Please use a new common test: ``` tde_setup_gcc_visibility( ) ```
if( NOT MSGFMT_EXECUTABLE )
tde_message_fatal( "msgfmt is required but was not found on your system." )
endif( NOT MSGFMT_EXECUTABLE )
endif( BUILD_TRANSLATIONS )
Owner

This is no longer needed – it is automatically served by the new common test tde_setup_msgfmt( ).

This is no longer needed – it is automatically served by the new common test `tde_setup_msgfmt( )`.
Ghost added the PR/wip label 5 years ago
Ghost added ST/wontfix and removed PR/wip labels 5 years ago
Ghost commented 5 years ago
Poster

So many change in the cmake modules, I get lost.
Feel free to add/change anything, I won't work on kshudown anymore.

So many change in the cmake modules, I get lost. Feel free to add/change anything, I won't work on kshudown anymore.
Owner

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.
SlavekB removed the ST/wontfix label 5 years ago
SlavekB self-assigned this 5 years ago
SlavekB added the PR/wip label 5 years ago
SlavekB removed the PR/wip label 5 years ago
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeConv 5 years ago
SlavekB added this to the R14.0.6 release milestone 5 years ago
The pull request has been merged as ffbcad84f2.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kshutdown#1
Loading…
There is no content yet.