#1 cmake conversion

Merged
SlavekB merged 3 commits from feat/cmakeConv into master 8 months ago
cethyel commented 8 months ago

I’ve added a man page taken from your Debian packaging system.

I've added a man page taken from your Debian packaging system.
SlavekB reviewed 8 months ago
Please, give attention to my comments below. For now, I did not test it but it looks good.
ConfigureChecks.cmake
@@ -0,0 +16,4 @@
include(TestBigEndian)
test_big_endian(WORDS_BIGENDIAN)


SlavekB

Please add here as another standard test:

tde_setup_largefiles( )
Please add here as another standard test: ``` tde_setup_largefiles( ) ```
@@ -0,0 +26,4 @@
set( __KDE_HAVE_GCC_VISIBILITY 1 )
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
endif( WITH_GCC_VISIBILITY )
SlavekB

Please use a new common test:

tde_setup_gcc_visibility( )
Please use a new common test: ``` tde_setup_gcc_visibility( ) ```
@@ -0,0 +41,4 @@
if( NOT MSGFMT_EXECUTABLE )
tde_message_fatal( "msgfmt is required but was not found on your system." )
endif( NOT MSGFMT_EXECUTABLE )
endif( BUILD_TRANSLATIONS )
SlavekB

This is no longer needed – it is automatically served by the new common test tde_setup_msgfmt( ).

This is no longer needed – it is automatically served by the new common test `tde_setup_msgfmt( )`.
cethyel added the
PR/wip
label 8 months ago
cethyel added the
ST/wontfix
label 8 months ago
cethyel removed the
PR/wip
label 8 months ago
cethyel commented 8 months ago
Poster

So many change in the cmake modules, I get lost.
Feel free to add/change anything, I won’t work on kshudown anymore.

So many change in the cmake modules, I get lost. Feel free to add/change anything, I won't work on kshudown anymore.
SlavekB commented 8 months ago
Owner

Okay, that’s no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I’ll finish it.

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.
SlavekB removed the
ST/wontfix
label 8 months ago
SlavekB self-assigned this 8 months ago
SlavekB added the
PR/wip
label 8 months ago
SlavekB removed the
PR/wip
label 8 months ago
SlavekB deleted branch feat/cmakeConv 8 months ago
SlavekB added this to the R14.0.6 release milestone 8 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.