Conversion to the cmake building system. #2

Merged
MicheleC merged 1 commits from feat/cmakeConv into master 2 years ago
Ghost commented 2 years ago

Made on the "go" since I couldn't build It with scons.

Made on the "go" since I couldn't build It with scons.
Ghost added the
PR/wip
label 2 years ago
Ghost changed title from WIP:Conversion to the cmake buildidng system. to WIP:Conversion to the cmake building system. 2 years ago
Ghost changed title from WIP:Conversion to the cmake building system. to Conversion to the cmake building system. 2 years ago
Ghost added
PR/rfc
and removed
PR/wip
labels 2 years ago
Poster

@SlavekB The differences with the Deb package is you have two desktop files:
one in, /opt/trinity/share/applications/kstreamripper.desktop
the other in, /opt/trinity/share/applications/tde/kstreamripper.desktop.
I've only installed the one in ../share/applications/tde/kstreamripper.desktop

Then you added a pixmap icon (Ubuntu stuff I believe).

I added a man page taken from your Deb packaging.

@SlavekB The differences with the Deb package is you have two desktop files: one in, /opt/trinity/share/applications/kstreamripper.desktop the other in, /opt/trinity/share/applications/tde/kstreamripper.desktop. I've only installed the one in ../share/applications/tde/kstreamripper.desktop Then you added a pixmap icon (Ubuntu stuff I believe). I added a man page taken from your Deb packaging.
Owner

I tested in debian/bullseye using this PR and PR #1 (python3 fix) and it works fine.

I tested in debian/bullseye using this PR and PR #1 (python3 fix) and it works fine.
Owner

Hi Greg,

as commented in #1, scons is causing dependency issues, since it requires different python versions between old and new distros (py2 and py3). Would you be able to rework this PR to totally drop scons and only use cmake?

For info, using this PR only (without #1) FTBFS in bullseye, for the same reasons explained in #1 (different python version.

Hi Greg,<br/> as commented in #1, scons is causing dependency issues, since it requires different python versions between old and new distros (py2 and py3). Would you be able to rework this PR to totally drop scons and only use cmake?<br/> For info, using this PR only (without #1) FTBFS in bullseye, for the same reasons explained in #1 (different python version.
Poster

Would you be able to rework this PR to totally drop scons and only use cmake?

@MicheleC unless I've missed something (just waking up here) the cmake conversion does not use anything from Scons or the Python interpreter.

>Would you be able to rework this PR to totally drop scons and only use cmake? @MicheleC unless I've missed something (just waking up here) the cmake conversion does not use anything from Scons or the Python interpreter.
Owner

I tried building kstreamripper using the cmake conversion on top of master and still fails here. I will double check just in case I made a mistake

I tried building kstreamripper using the cmake conversion on top of master and still fails here. I will double check just in case I made a mistake
Owner

The PR works fine after adjusting the packaging files on the packaging repo (TDE/tde-packaging#64).

The PR works fine after adjusting the packaging files on the packaging repo (TDE/tde-packaging#64).
MicheleC added this to the R14.0.8 release milestone 2 years ago
Owner

I removed a few unnecessary files.

Once we get rid of automake files, we can also get rid of SCons files too.

I removed a few unnecessary files.<br/> Once we get rid of automake files, we can also get rid of SCons files too.
MicheleC closed this pull request 2 years ago
MicheleC deleted branch feat/cmakeConv 2 years ago
Owner

Thanks Greg, excellent job as usual!

Thanks Greg, excellent job as usual!
The pull request has been merged as 3db0e4b4ea.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.