Add top-left main window icon (hi*-app-kstreamripper.png) #3

Merged
MicheleC merged 1 commits from fix/mainWindowIcon into master 1 year ago
Ghost commented 1 year ago

I don't know what icon was displayed before but I put the one provided with kstreamripper.

I don't know what icon was displayed before but I put the one provided with kstreamripper.
Ghost added 1 commit 1 year ago
ac5847e869
Add top-left main window icon (hi*-app-kstreamripper.png)
Poster

Not related to this PR but one can note that kstreamripper make use of xmms by default https://mirror.git.trinitydesktop.org/gitea/TDE/kstreamripper/src/branch/master/src/kstreamripper.cpp#L69

I know you Deb guy haven't got xmms anymore, we might/could use something else here.

Not related to this PR but one can note that kstreamripper make use of xmms by default https://mirror.git.trinitydesktop.org/gitea/TDE/kstreamripper/src/branch/master/src/kstreamripper.cpp#L69 I know you Deb guy haven't got xmms anymore, we might/could use something else here.
Owner

Looks good, thanks Greg.

Looks good, thanks Greg.
MicheleC merged commit ac5847e869 into master 1 year ago
MicheleC deleted branch fix/mainWindowIcon 1 year ago
MicheleC added this to the R14.0.10 release milestone 1 year ago
Owner

Not related to this PR but one can note that kstreamripper make use of xmms by default https://mirror.git.trinitydesktop.org/gitea/TDE/kstreamripper/src/branch/master/src/kstreamripper.cpp#L69

I know you Deb guy haven't got xmms anymore, we might/could use something else here.

Good point. We should add detection of the actual version of xmms available. Debian has xmms2, no more xmms around.

> Not related to this PR but one can note that kstreamripper make use of xmms by default https://mirror.git.trinitydesktop.org/gitea/TDE/kstreamripper/src/branch/master/src/kstreamripper.cpp#L69 > > I know you Deb guy haven't got xmms anymore, we might/could use something else here. Good point. We should add detection of the actual version of xmms available. Debian has xmms2, no more xmms around.
The pull request has been merged as ac5847e869.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.