Conversion to the cmake building system. #2

Merged
SlavekB merged 2 commits from feat/cmakeConv into master 1 year ago
cethyel commented 2 years ago
Collaborator
There is no content yet.
cethyel added the
PR/wip
label 2 years ago
cethyel removed the
PR/wip
label 2 years ago
cethyel changed title from WIP:Conversion to the cmake building system. to Conversion to the cmake building system. 2 years ago
SlavekB reviewed 1 year ago
SlavekB left a comment

It looks good. There is only one small comment.

SOURCES
ksystemlogConfig.kcfgc
dummyConfig.cpp
SlavekB commented 1 year ago
Poster
Owner

The use of dummyConfig.cpp is not needed in this case.

An empty dummy file is required if no other source file is specified. In this case, the ksystemlogConfig.kcfgc file is listed here, so an empty dummy file is not needed.

The use of `dummyConfig.cpp` is not needed in this case. An empty dummy file is required if no other source file is specified. In this case, the `ksystemlogConfig.kcfgc` file is listed here, so an empty dummy file is not needed.
Owner

I noticed that there are no translations built during automake building. Thanks to this, we can subsequently change the layout of the translation directory without any worries.

I noticed that there are no translations built during automake building. Thanks to this, we can subsequently change the layout of the translation directory without any worries.
Poster
Collaborator

I've removed the cpp dummy file.

I've removed the cpp dummy file.
cethyel added the
PR/wip
label 1 year ago
Poster
Collaborator

I have changed the directory layout for the po files, please test.
If it's ok then I'll squash my commits and I'll let you handle the desktop file translations stuff.

I have changed the directory layout for the po files, please test. If it's ok then I'll squash my commits and I'll let you handle the desktop file translations stuff.
Owner

I have changed the directory layout for the po files, please test.
If it's ok then I'll squash my commits and I'll let you handle the desktop file translations stuff.

Please note that it is still true that changing the layout of directories with translations must be done in successive steps – first copy, then change the settings in the TWTW and only then it is possible to delete files from the original location. Otherwise, we would lose the continuity of history in the TWTW.

> I have changed the directory layout for the po files, please test. > If it's ok then I'll squash my commits and I'll let you handle the desktop file translations stuff. Please note that it is still true that changing the layout of directories with translations must be done in successive steps – first copy, then change the settings in the TWTW and only then it is possible to delete files from the original location. Otherwise, we would lose the continuity of history in the TWTW.
Poster
Collaborator

Please note that it is still true that changing the layout of directories with translations must be done in successive steps...

Because you said:

noticed that there are no translations built during automake building. Thanks to this, we can subsequently change the layout of the translation directory without any worries.

My bad, I understood quite the opposite (we could skip the steps you mentionned).

> Please note that it is still true that changing the layout of directories with translations must be done in successive steps... Because you said: > noticed that there are no translations built during automake building. Thanks to this, we can subsequently change the layout of the translation directory without any worries. My bad, I understood quite the opposite (we could skip the steps you mentionned).
Owner

Please note that it is still true that changing the layout of directories with translations must be done in successive steps...

Because you said:

noticed that there are no translations built during automake building. Thanks to this, we can subsequently change the layout of the translation directory without any worries.

My bad, I understood quite the opposite (we could skip the steps you mentionned).

Oh, yes, I'm inaccurate. We don't have to worry about automake, but it's still true that changing the layout of translation files requires two separate steps so that there is time to change the settings in Weblate.

> > Please note that it is still true that changing the layout of directories with translations must be done in successive steps... > > Because you said: > > noticed that there are no translations built during automake building. Thanks to this, we can subsequently change the layout of the translation directory without any worries. > > My bad, I understood quite the opposite (we could skip the steps you mentionned). > > Oh, yes, I'm inaccurate. We don't have to worry about automake, but it's still true that changing the layout of translation files requires two separate steps so that there is time to change the settings in Weblate.
Owner

I think everything looks good. I leave the extraction of strings from the desktop file for the next round – until the automake build is removed.

I think everything looks good. I leave the extraction of strings from the desktop file for the next round – until the automake build is removed.
SlavekB removed the
PR/wip
label 1 year ago
SlavekB merged commit 3672a06db5 into master 1 year ago
SlavekB added this to the R14.0.9 release milestone 1 year ago
SlavekB deleted branch feat/cmakeConv 1 year ago
Owner

Greg, thank you, good job. It's great to see how CMake conversion progresses successfully!

Greg, thank you, good job. It's great to see how CMake conversion progresses successfully!
Owner

Great, another one apps converted!! Excellent effort guys 😄

Great, another one apps converted!! Excellent effort guys :smile:
The pull request has been merged as 3672a06db5.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.