Drop TQT_BASE_OBJECT* defines #6

Merged
MicheleC merged 1 commits from drop/tqt-base-object-defines into master 1 year ago
Owner

TQT_BASE_OBJECT* defines will later be removed from tqtinterface.

TQT_BASE_OBJECT* defines will later be removed from tqtinterface.
MicheleC added this to the R14.1.1 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
ef1ce91387
Drop TQT_BASE_OBJECT* defines
MicheleC requested review from Core 1 year ago
MicheleC requested review from Owners 1 year ago
MicheleC force-pushed drop/tqt-base-object-defines from ef1ce91387 to eb7bd96c05 1 year ago
MicheleC force-pushed drop/tqt-base-object-defines from eb7bd96c05 to 32c3c23804 1 year ago
SlavekB requested changes 1 year ago
SlavekB left a comment
Owner

I think the remaining const_cast<...> is unnecessary.

I think the remaining `const_cast<...>` is unnecessary.
#if defined(TDE_MAKE_VERSION) && (TDE_VERSION >= TDE_MAKE_VERSION(3,4,0))
void SlotLogAction::slotLogAction(TDEAction::ActivationReason reason, TQt::ButtonState state) {
const TQObject* sender=TQT_TQOBJECT(const_cast<TQT_BASE_OBJECT_NAME*>(TQObject::sender()));
const TQObject* sender=const_cast<TQObject*>(TQObject::sender());
SlavekB commented 1 year ago
Owner

It would be sufficient here too: const TQObject* sender=TQObject::sender();?

It would be sufficient here too: `const TQObject* sender=TQObject::sender();`?
Poster
Owner

PR updated, thanks for catching that.

PR updated, thanks for catching that.
MicheleC marked this conversation as resolved
MicheleC force-pushed drop/tqt-base-object-defines from 32c3c23804 to 06e303d75a 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 06e303d75a into master 1 year ago
MicheleC deleted branch drop/tqt-base-object-defines 1 year ago
SlavekB referenced this issue from a commit 1 year ago
SlavekB referenced this issue from a commit 1 year ago
SlavekB referenced this issue from a commit 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
TDE/Core was requested for review 1 year ago
The pull request has been merged as 06e303d75a.
Sign in to join this conversation.
No reviewers
TDE/Core
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/ksystemlog#6
Loading…
There is no content yet.