TDE
/
kvkbd
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

empty files KeyClip.* #1

Closed
opened 6 years ago by Ghost · 4 comments
Ghost commented 6 years ago

KeyClip.cpp and KeyClip.h are empty files.

I don't know what they're for...

I grabbed kvkb-0.5 sources and these files are still there...empty!

I'll try to build kvkbd without them, see if It builds fine.

KeyClip.cpp and KeyClip.h are empty files. I don't know what they're for... I grabbed kvkb-0.5 sources and these files are still there...empty! I'll try to build kvkbd without them, see if It builds fine.
Ghost commented 6 years ago
Poster

Well, It does build without them and kvkbd seems to work properly.

What do you think about deleting these files from the sources?

Well, It does build without them and kvkbd seems to work properly. What do you think about deleting these files from the sources?
MicheleC commented 6 years ago
Owner

sounds good to me 👍

sounds good to me :+1:
Ghost commented 6 years ago
Poster

I'll see for a PR tomorrow.

Bye guys!

I'll see for a PR tomorrow. Bye guys!
MicheleC closed this issue 6 years ago
MicheleC commented 6 years ago
Owner

Solved by PR #2

Solved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/kvkbd/pulls/2
SlavekB added this to the R14.0.6 release milestone 6 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
r14.0.x
v3.5.13-sru
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kvkbd#1
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes