TDE
/
kvkbd
6
0
Förgrening 0
Kod Ärenden Pull-förfrågningar Släpp Wiki Aktiviteter
Etiketter Milstenar
Nytt Ärende

empty files KeyClip.* #1

Stängd
opened 6 år sedan by Ghost · 4 kommentarer
Ghost kommenterad 6 år sedan

KeyClip.cpp and KeyClip.h are empty files.

I don't know what they're for...

I grabbed kvkb-0.5 sources and these files are still there...empty!

I'll try to build kvkbd without them, see if It builds fine.

KeyClip.cpp and KeyClip.h are empty files. I don't know what they're for... I grabbed kvkb-0.5 sources and these files are still there...empty! I'll try to build kvkbd without them, see if It builds fine.
Ghost kommenterad 6 år sedan
Skapare

Well, It does build without them and kvkbd seems to work properly.

What do you think about deleting these files from the sources?

Well, It does build without them and kvkbd seems to work properly. What do you think about deleting these files from the sources?
MicheleC kommenterad 6 år sedan
Ägare

sounds good to me 👍

sounds good to me :+1:
Ghost kommenterad 6 år sedan
Skapare

I'll see for a PR tomorrow.

Bye guys!

I'll see for a PR tomorrow. Bye guys!
MicheleC stängde ärendet 6 år sedan
MicheleC kommenterad 6 år sedan
Ägare

Solved by PR #2

Solved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/kvkbd/pulls/2
SlavekB lade till denna till milstolpe R14.0.6 release 6 år sedan
Logga in för att delta i denna konversation.
Ingen Branch/Tag specificerad
Grenar Taggar
r14.1.x
master
r14.0.x
v3.5.13-sru
Etiketter
Tillämpa etiketter
Rensa etiketter
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Ingen Etikett GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
R14.0.6 release
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/kvkbd#1
Skriv Förhandsgranska
Laddar…
Avbryt
Spara
Det finns inget innehåll än.
Ta bort branch '%!s(<nil>)'

Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?

Nej
Ja