#3 remove unnecessary variable and rename some

Closed
opened 1 year ago by cethyel · 3 comments
cethyel commented 1 year ago

In main.cpp, the findAloneWindow() function:

The variable “mapped” is not used, I’d like to get rid of It.

I’d like to rename the parameters “r” and “p” to something a bit more meaningful, for instance:

r --> root_id

p --> parent_id

Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html

In main.cpp, the findAloneWindow() function: The variable "mapped" is not used, I'd like to get rid of It. I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance: r --> root_id p --> parent_id Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html
MicheleC commented 1 year ago
Owner

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:
cethyel commented 1 year ago
Poster

If It would have been about the removal of the variable only, I wouldn’t ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.
SlavekB commented 11 months ago
Owner

Resolved by PR #5

Resolved by PR #5
SlavekB added this to the R14.0.6 release milestone 11 months ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.