TDE
/
kvkbd
6
0
Vork 0
Code Kwesties Pull-aanvragen Publicaties Wiki Activiteit
Labels Mijlpalen
Nieuw probleem

remove unnecessary variable and rename some #3

Closed
opened 6 jaren geleden by Ghost · 3 comments
Ghost commented 6 jaren geleden

In main.cpp, the findAloneWindow() function:

The variable "mapped" is not used, I'd like to get rid of It.

I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance:

r --> root_id

p --> parent_id

Some doc about the XQueryTree function:
https://tronche.com/gui/x/xlib/window-information/XQueryTree.html

In main.cpp, the findAloneWindow() function: The variable "mapped" is not used, I'd like to get rid of It. I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance: r --> root_id p --> parent_id Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html
MicheleC commented 6 jaren geleden
Eigenaar

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly 😉

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:
Ghost commented 6 jaren geleden
Poster

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.
SlavekB commented 6 jaren geleden
Eigenaar

Resolved by PR #5

Resolved by PR #5
SlavekB heeft dit 6 jaren geleden aan de mijlpaal R14.0.6 release toegevoegd
SlavekB heeft dit probleem gesloten 6 jaren geleden
Log in om deel te nemen aan deze discussie.
Geen Branch/Tag gespecificeerd
Branches Labels
r14.1.x
master
r14.0.x
v3.5.13-sru
Labels
Labels toepassen
Verwijder labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Geen label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Mijlpaal
Stel mijlpaal in
Verwijder mijlpaal
Geen items
Geen mijlpaal
R14.0.6 release
Toegewezen aan
Gebruikers toewijzen
Verwijder toegewezen aan
Niet toegewezen
3 deelnemers
Notificaties
Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: TDE/kvkbd#3
Schrijf Voorbeeld
Laden…
Annuleren
Opslaan
Er is nog geen inhoud.
Verwijder branch '%!s(<nil>)'

Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?

Nee
Ja