remove unnecessary variable and rename some #3

Закрыто
открыт 6 лет назад пользователем Ghost · комментариев: 3
Ghost прокомментировал(а) 6 лет назад

In main.cpp, the findAloneWindow() function:

The variable "mapped" is not used, I'd like to get rid of It.

I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance:

r --> root_id

p --> parent_id

Some doc about the XQueryTree function:
https://tronche.com/gui/x/xlib/window-information/XQueryTree.html

In main.cpp, the findAloneWindow() function: The variable "mapped" is not used, I'd like to get rid of It. I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance: r --> root_id p --> parent_id Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html
MicheleC прокомментировал(а) 6 лет назад
Владелец

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly 😉

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:
Ghost прокомментировал(а) 6 лет назад
Автор

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.
SlavekB прокомментировал(а) 6 лет назад
Владелец

Resolved by PR #5

Resolved by PR #5
SlavekB добавил(а) к этапу R14.0.6 release 6 лет назад
SlavekB закрыл(а) эту задачу 6 лет назад
Войдите, чтобы присоединиться к обсуждению.
Нет этапа
Нет назначенных лиц
3 участников
Уведомления
Срок выполнения

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Reference: TDE/kvkbd#3
Загрузка…
Пока нет содержимого.