TDE
/
kvkbd
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

remove unnecessary variable and rename some #3

Closed
opened 6 years ago by Ghost · 3 comments
Ghost commented 6 years ago

In main.cpp, the findAloneWindow() function:

The variable "mapped" is not used, I'd like to get rid of It.

I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance:

r --> root_id

p --> parent_id

Some doc about the XQueryTree function:
https://tronche.com/gui/x/xlib/window-information/XQueryTree.html

In main.cpp, the findAloneWindow() function: The variable "mapped" is not used, I'd like to get rid of It. I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance: r --> root_id p --> parent_id Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html
MicheleC commented 6 years ago
Owner

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly 😉

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:
Ghost commented 6 years ago
Poster

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.
SlavekB commented 6 years ago
Owner

Resolved by PR #5

Resolved by PR #5
SlavekB added this to the R14.0.6 release milestone 6 years ago
SlavekB closed this issue 6 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
r14.0.x
v3.5.13-sru
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kvkbd#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes