TDE
/
kvkbd
6
0
Çatalla 0
Kod Konular Değişiklik İstekleri Sürüm Wiki Aktivite
Etiketler Kilometre Taşları
Yeni Konu

remove unnecessary variable and rename some #3

Kapalı
Ghost tarafından 6 yıl önce açıldı · 3 yorum
Ghost 6 yıl önce yorum yaptı

In main.cpp, the findAloneWindow() function:

The variable "mapped" is not used, I'd like to get rid of It.

I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance:

r --> root_id

p --> parent_id

Some doc about the XQueryTree function:
https://tronche.com/gui/x/xlib/window-information/XQueryTree.html

In main.cpp, the findAloneWindow() function: The variable "mapped" is not used, I'd like to get rid of It. I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance: r --> root_id p --> parent_id Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html
MicheleC 6 yıl önce yorum yaptı
Sahibi

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly 😉

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:
Ghost 6 yıl önce yorum yaptı
Poster

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.
SlavekB 6 yıl önce yorum yaptı
Sahibi

Resolved by PR #5

Resolved by PR #5
SlavekB 6 yıl önce R14.0.6 release kilometre taşına ekledi
SlavekB 6 yıl önce konusunu kapattı
Bu konuşmaya katılmak için oturum aç.
Bölüm/Etiket Belirtilmedi
Dal Etiket
r14.1.x
master
r14.0.x
v3.5.13-sru
Etiketler
Etiketleri uygula
Etiketleri temizle
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Etiket Yok GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Kilometre Taşı
Kilometre taşı ayarla
Kilometre Taşlarını Temizle
Öge yok
Kilometre Taşı Yok
R14.0.6 release
Atananlar
Kullanıcı ata
Atamaları Temizle
Atanan Kişi Yok
3 Katılımcı
Bildirimler
Bitiş Tarihi

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: TDE/kvkbd#3
Yaz Önizleme
Yükleniyor…
İptal
Kaydet
Henüz bir içerik yok.
'%!s(<nil>)' Dalını Sil

Bir dalı silmek kalıcıdır. GERİ ALINAMAZ. Devam edilsin mi?

Hayır
Evet