remove unnecessary variable and rename some #3

已关闭
由 Ghost 于 6 年前 打开 · 3 条评论
Ghost 评论于 6 年前

In main.cpp, the findAloneWindow() function:

The variable "mapped" is not used, I'd like to get rid of It.

I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance:

r --> root_id

p --> parent_id

Some doc about the XQueryTree function:
https://tronche.com/gui/x/xlib/window-information/XQueryTree.html

In main.cpp, the findAloneWindow() function: The variable "mapped" is not used, I'd like to get rid of It. I'd like to rename the parameters "r" and "p" to something a bit more meaningful, for instance: r --> root_id p --> parent_id Some doc about the XQueryTree function: https://tronche.com/gui/x/xlib/window-information/XQueryTree.html
MicheleC 评论于 6 年前
所有者

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly 😉

Sounds good to me. Actually for this kind of small changes, feel free to prepare the code and PR directly :wink:
Ghost 评论于 6 年前
发布者

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.

If It would have been about the removal of the variable only, I wouldn't ask ; but I had to know if you were willing to rename things here and there, therefore I snapped the occasion up.
SlavekB 评论于 6 年前
所有者

Resolved by PR #5

Resolved by PR #5
SlavekB6 年前 添加了里程碑 R14.0.6 release
SlavekB6 年前 关闭此工单
登录 并参与到对话中。
未选择里程碑
未指派成员
3 名参与者
通知
到期时间

未设置到期时间。

依赖工单

没有设置依赖项。

参考:TDE/kvkbd#3
正在加载...
这个人很懒,什么都没留下。