Remove CMakeLists.txt in doc/ and translations/ #5
Merged
SlavekB
merged 1 commits from rfc/docs_translations_macros
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'rfc/docs_translations_macros'
Deleting a branch is permanent. It CANNOT be undone. Continue?
.desktop files generation is not implemented from a local CMakeLists.txt.
As the CMakeLists.txt for translations and docs are now one-liners, wouldn't it make sense to also remove those and incorporate the macro call in the CMakeLists.txt in the source root directory?
I've used kvpnc as the test-bed for this because it has doc/man, doc/misc, and translations/messages already set up.
Just to clarify here, under these common rules, the source .po files are translations/messages/lang.po.
These additions are for testing and won't feature in any final PR:
To demonstrate that doc/en/kcontrol installs correctly, I've copied it to here so that it's included in the build.
I also did a test build with the knemo translations added, and they installed correctly.
For kdbg, for example, the doc directory would have to be moved up a level from the kdbg subdirectory.
But then that would be a good thing, to have the doc and translations sources in the same relative positions in the source tree for all applications.
I was going to update this PR to a merge candidate now that cmake pull 72 has been merged, but I can't log in.
Expect:
Actually get:
Is the problem with me or the server?
I don't know about any problem – I tried fetch and push (although there were no changes on my side) and everything went well.
As you can see on TDE/k3b-i18n#1, I pushed committs without problems. https with authorization was also used to push it.
0195136bda
todf31e02c1f
3 years agoWIP: Remove CMakeLists.txt in doc/ and translations/to Remove CMakeLists.txt in doc/ and translations/ 3 years agoWhatever the login problem was, it's cleared up now.
Removed kcontrol test case.
Changes are now:
It looks good. Files from
doc/misc
have not previously installed, now are installed, and it seems like a good idea.Well done Ray, thanks for the good work.
df31e02c1f
into master 3 years agoReviewers
df31e02c1f
.