cmake conversion #1

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 5 years ago
Ghost commented 5 years ago

On Slackware (pkg-config --cflags exiv2) doesn't display anything since exiv2 is installed in /usr/include but I've added {EXIV2_INCLUDE_DIRS} to the CMakeLists.txt (can be removed).

Automake sets the release version to 5.0.0 but I've set It up to 0.1.9 like in the version.h header.

On Slackware $(pkg-config --cflags exiv2) doesn't display anything since exiv2 is installed in /usr/include but I've added ${EXIV2_INCLUDE_DIRS} to the CMakeLists.txt (can be removed). Automake sets the release version to 5.0.0 but I've set It up to 0.1.9 like in the version.h header.
Ghost added the PR/rfc label 5 years ago
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

The issues listed below need to be resolved. Apart from these little things, it looks good.

The issues listed below need to be resolved. Apart from these little things, it looks good.
##### other data
configure_file( ${PROJECT_NAME}.pc.cmake ${PROJECT_NAME}.pc )
Owner

Here you need to use @ONLY to avoid undesirable processing of ${libdir} and ${includedir} in generated pkg-config file.

Here you need to use `@ONLY` to avoid undesirable processing of `${libdir}` and `${includedir}` in generated pkg-config file.
tdecore-shared
${EXIV2_LIBRARIES}
VERSION 0.1.9
Owner

The numbering of SO libraries is a bit complicated. SO numbers may not be related to the official version of the library. This is related to changes in the library API. See chapter Updating library version information in libtool documentation. Therefore, we need to keep the same SO version so as not to cause confusion in API compatibility.

The numbering of SO libraries is a bit complicated. SO numbers may not be related to the official version of the library. This is related to changes in the library API. See chapter [Updating library version information](https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html) in libtool documentation. Therefore, we need to keep the same SO version so as not to cause confusion in API compatibility.
Owner

It would be nice if ${prefix} was used in the pkg-config file where possible. See example in TDE/artsCMakeLists.txt and arts.pc.cmake. The same applies to TDE/libkipi#1.

It would be nice if `${prefix}` was used in the pkg-config file where possible. See example in [TDE/arts](../arts) – [CMakeLists.txt](https://mirror.git.trinitydesktop.org/gitea/TDE/arts/src/branch/master/CMakeLists.txt#L271) and [arts.pc.cmake](https://mirror.git.trinitydesktop.org/gitea/TDE/arts/src/branch/master/arts.pc.cmake). The same applies to TDE/libkipi#1.
SlavekB approved these changes 5 years ago
SlavekB left a comment
Owner

Thank you, good work.

Thank you, good work.
SlavekB removed the PR/rfc label 5 years ago
SlavekB added this to the R14.0.7 release milestone 5 years ago
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeConv 5 years ago
The pull request has been merged as 5055b406cd.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libkexiv2#1
Loading…
There is no content yet.