TDE
/
libr
6
0
Fork 1
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fixed generation of corrupted executables when editing sections. #5

Merged
MicheleC merged 1 commits from issue/4/libr into master 4 years ago
Conversation 5 Commits 1 Files Changed 1
MicheleC commented 4 years ago
Owner

Tested in bullseye. Please in older distro. Make sure to build tdelibs after rebuilding libr. If tdelibs builds fine, it is good.

Tested in bullseye. Please in older distro. Make sure to build tdelibs after rebuilding libr. If tdelibs builds fine, it is good.
MicheleC added the PR/rfc label 4 years ago
MicheleC added this to the R14.0.9 release milestone 4 years ago
Ghost commented 4 years ago

tdelibs and tdebase are building fine, TDE lunches fine ; minus I don't run binutils-2.34.90.20200706 but binutils-2.33.1.

tdelibs and tdebase are building fine, TDE lunches fine ; minus I don't run binutils-2.34.90.20200706 but binutils-2.33.1.
MicheleC commented 4 years ago
Poster
Owner

tdelibs and tdebase are building fine, TDE lunches fine ; minus I don't run binutils-2.34.90.20200706 but binutils-2.33.1.

The problem is with binutils 2.34.90 or higher 😄

> tdelibs and tdebase are building fine, TDE lunches fine ; minus I don't run binutils-2.34.90.20200706 but binutils-2.33.1. > The problem is with binutils 2.34.90 or higher :smile:
Ghost commented 4 years ago

... Please in older distro. Make sure to build tdelibs after rebuilding libr...

Seems to me, that my test build is as good as what you just asked here.

>... Please in older distro. Make sure to build tdelibs after rebuilding libr... Seems to me, that my test build is as good as what you just asked here.
MicheleC commented 4 years ago
Poster
Owner

... Please in older distro. Make sure to build tdelibs after rebuilding libr...

Seems to me, that my test build is as good as what you just asked here.

eh eh, you are right actually 👍

> >... Please in older distro. Make sure to build tdelibs after rebuilding libr... > > Seems to me, that my test build is as good as what you just asked here. eh eh, you are right actually :+1:
SlavekB commented 4 years ago
Owner

Successfully built libr and tdelibs on Wheezy => binutils 2.22-8+deb7u2.

Successfully built libr and tdelibs on Wheezy => binutils 2.22-8+deb7u2.
SlavekB requested changes 4 years ago
SlavekB left a comment
Owner

The second part of the patch causes problems – leads to FTBFS in tdelibs.

The second part of the patch causes problems – leads to FTBFS in tdelibs.
src/libr-bfd.c
}
}
}
if(!bfd_copy_private_bfd_data(ihandle, ohandle))
SlavekB commented 4 years ago
Owner

This removal causes problems - FTBFS in tdelibs – it occurred on ppc64el and armhf, then I tested successfully without this removal.

This removal causes problems - FTBFS in tdelibs – it occurred on ppc64el and armhf, then I tested successfully without this removal.
MicheleC commented 4 years ago
Poster
Owner

ok, will revert this soon, thanks for testing other archs.

Commit updated.

ok, will revert this soon, thanks for testing other archs. Commit updated.
MicheleC marked this conversation as resolved
MicheleC requested review from SlavekB 4 years ago
SlavekB approved these changes 4 years ago
SlavekB left a comment
Owner

Successfully tested on various distributions (Wheezy, Jessie, Stretch, Buster, Bullseye) and various architectures (amd64, ppc64el, arm64, armhf, mips, powerpc).

Successfully tested on various distributions (Wheezy, Jessie, Stretch, Buster, Bullseye) and various architectures (amd64, ppc64el, arm64, armhf, mips, powerpc).
MicheleC merged commit ed09509e0b into master 4 years ago
MicheleC removed the PR/rfc label 4 years ago
MicheleC deleted branch issue/4/libr 4 years ago

Reviewers

SlavekB approved these changes 4 years ago
The pull request has been merged as ed09509e0b.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libr#5
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/4/libr'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes