WIP [NOT FOR MERGING]: code style effort #7

Closed
MicheleC wants to merge 2 commits from MicheleC:feat/code-formatting into master
Owner

This PR is the first attempt at code styling for libr.
The reasons to start from libr is that it is the first package to be built (besided extra deps) and it is very small.

This PR is meant as a review space, where we can all examine the results, point outs what is not ok and later review after fixes have been applied. It is recommended to look at the files on CLI and checking for spaces/tabs as well.

There are still things to be fixed, but more people looking at the results are likely to spot more problems than a single person. It would be great if you could spend some time to go through the files and highlight (as comments in the PR code) things that are not quite right. I will later work on getting those fixed. Note, you can safely skip the .format_errorsX.txt files and the config file .uncrustify_tde.cfg

Current version has been formatted using upstream uncrustify as of commit dedc17ad with the config file included in this PR.

This PR is the first attempt at code styling for libr. The reasons to start from libr is that it is the first package to be built (besided extra deps) and it is very small. This PR is meant as a review space, where we can all examine the results, point outs what is not ok and later review after fixes have been applied. It is recommended to look at the files on CLI and checking for spaces/tabs as well. There are still things to be fixed, but more people looking at the results are likely to spot more problems than a single person. It would be great if you could spend some time to go through the files and highlight (as comments in the PR code) things that are not quite right. I will later work on getting those fixed. Note, you can safely skip the .format_errorsX.txt files and the config file .uncrustify_tde.cfg Current version has been formatted using upstream uncrustify as of commit dedc17ad with the config file included in this PR.
MicheleC added 2 commits 3 years ago
c42c6786e7
First uncrustify pass.
56bb40fc00
Second uncrustify pass.
Poster
Owner

Note, I am using a forked repository and not the official libr one because I expect this work to take some time and consume some disk space. Once we are happy with the result, we can simply format the official repo and delete this one.

Also, after we are done with libr, we will progressively work on bigger repos, again fixing new issues as they arise while at the same time making sure already formatted repos remain unchanged.

Note, I am using a forked repository and not the official libr one because I expect this work to take some time and consume some disk space. Once we are happy with the result, we can simply format the official repo and delete this one. Also, after we are done with libr, we will progressively work on bigger repos, again fixing new issues as they arise while at the same time making sure already formatted repos remain unchanged.
MicheleC added the PR/rfc PR/wip labels 3 years ago
MicheleC requested review from SlavekB 3 years ago
MicheleC requested review from blu.256 3 years ago
MicheleC requested review from Ghost 3 years ago
MicheleC removed the PR/rfc PR/wip labels 3 years ago
MicheleC removed review request for SlavekB 3 years ago
MicheleC removed review request for Ghost 3 years ago
MicheleC removed review request for blu.256 3 years ago
MicheleC added the PR/not-ok ST/rejected labels 3 years ago
Poster
Owner

Apologies, created PR in wrong repo. Closing and please ignore!

Apologies, created PR in wrong repo. Closing and please ignore!
MicheleC closed this pull request 3 years ago
MicheleC added the PR/keep-branch label 3 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libr#7
Loading…
There is no content yet.