TDE
/
libtdeldap
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones

Fix detection of older Heimdal versions #4

Merged
SlavekB merged 1 commits from feat/fix-old-heimdal-detection into master 5 years ago
Conversation 1 Commits 1 Files Changed 1
SlavekB commented 5 years ago
Owner

Some older Heimdal versions may refer for include files to /usr/include in the pkg-config file although the necessary files are in /usr/include/heimdal. Similarly, for libraries it can refer to /usr/lib although the necessary libraries are in the heimdal subdirectory.

Patch in this pull request adds a check to see if the detected paths are really accurate and set it to the necessary values if needed.

Some older Heimdal versions may refer for include files to `/usr/include` in the pkg-config file although the necessary files are in `/usr/include/heimdal`. Similarly, for libraries it can refer to `/usr/lib` although the necessary libraries are in the `heimdal` subdirectory. Patch in this pull request adds a check to see if the detected paths are really accurate and set it to the necessary values if needed.
SlavekB added this to the R14.1.0 release milestone 5 years ago
MicheleC approved these changes 5 years ago
MicheleC left a comment
Owner

Look good.

Look good.
SlavekB commented 5 years ago
Poster
Owner

Added (OUTPUT|ERORR)_STRIP_TRAILING_WHITESPACE in execute_process calls to avoid CMP0004.

Added `(OUTPUT|ERORR)_STRIP_TRAILING_WHITESPACE` in `execute_process` calls to avoid CMP0004.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/fix-old-heimdal-detection 5 years ago
The pull request has been merged as 9ca53813e2.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libtdeldap#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/fix-old-heimdal-detection'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes