#3 cmake conversion

Merged
SlavekB merged 6 commits from feat/cmakeConv into master 8 months ago
cethyel commented 9 months ago

The “doc” and “po” folder are actually empty, as a result I’ve left them commented in the CMakeLists.txt.

I’ve added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
cethyel added the
PR/rfc
label 9 months ago
SlavekB started working 8 months ago
SlavekB stopped working 8 months ago
1h 55min 5s
SlavekB commented 8 months ago
Owner

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I’ll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB changed title from cmake conversion to WIP: cmake conversion 8 months ago
SlavekB added the
PR/wip
label 8 months ago
SlavekB commented 8 months ago
Owner

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That’s why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB commented 8 months ago
Owner

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB changed title from WIP: cmake conversion to cmake conversion 8 months ago
SlavekB removed the
PR/wip
label 8 months ago
SlavekB removed the
PR/rfc
label 8 months ago
SlavekB deleted branch feat/cmakeConv 8 months ago
SlavekB added this to the R14.0.6 release milestone 8 months ago
The pull request has been merged.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Total Time Spent: 1h 55min 5s
Slávek Banko
1h 55min 5s
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.