cmake conversion #3

Обединени
SlavekB обедини 1 ревизии от feat/cmakeConv във master преди 5 години
Ghost коментира преди 5 години

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost added the PR/rfc label преди 5 години
SlavekB started working преди 5 години
SlavekB stopped working преди 5 години
1h 55min 5s
Притежател

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB changed title from cmake conversion to WIP: cmake conversion преди 5 години
SlavekB added the PR/wip label преди 5 години
Притежател

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
Притежател

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB changed title from WIP: cmake conversion to cmake conversion преди 5 години
SlavekB removed the PR/wip label преди 5 години
SlavekB closed this pull request преди 5 години
SlavekB removed the PR/rfc label преди 5 години
SlavekB deleted branch feat/cmakeConv преди 5 години
SlavekB added this to the R14.0.6 release milestone преди 5 години
Тази заявка за сливане е била обединена като cdbb1c0a4c.
Впишете се за да се присъедините към разговора.
No reviewers
Няма етап
Няма изпълнители
2 участника
Известия
Total Time Spent: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
Due Date

No due date set.

Зависимости

No dependencies set.

Reference: TDE/libtdeldap#3
Зареждане…
Все още няма съдържание.