6
0
Fork 0

cmake conversion #3

Zusammengeführt
SlavekB hat 1 Commits von feat/cmakeConv nach master vor 5 Jahren zusammengeführt
Ghost hat vor 5 Jahren kommentiert

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost hat das Label PR/rfc vor 5 Jahren hinzugefügt
SlavekB hat die Zeiterfassung vor 5 Jahren gestartet
SlavekB hat die Zeiterfassung vor 5 Jahren angehalten
1h 55min 5s
SlavekB hat vor 5 Jahren kommentiert
Besitzer

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB hat den Titel von cmake conversion zu WIP: cmake conversion vor 5 Jahren geändert
SlavekB hat das Label PR/wip vor 5 Jahren hinzugefügt
SlavekB hat vor 5 Jahren kommentiert
Besitzer

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB hat vor 5 Jahren kommentiert
Besitzer

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB hat den Titel von WIP: cmake conversion zu cmake conversion vor 5 Jahren geändert
SlavekB hat das Label PR/wip vor 5 Jahren entfernt
SlavekB hat diesen Pull-Request vor 5 Jahren geschlossen
SlavekB hat das Label PR/rfc vor 5 Jahren entfernt
SlavekB löschte die Branch feat/cmakeConv vor 5 Jahren
SlavekB hat diesen Issue vor 5 Jahren zum R14.0.6 release Meilenstein hinzugefügt
Der Pull Request wurde als cdbb1c0a4c gemergt.
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Niemand zuständig
2 Beteiligte
Nachrichten
Aufgewendete Zeit: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
Fällig am

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: TDE/libtdeldap#3
Laden…
Hier gibt es bis jetzt noch keinen Inhalt.