cmake conversion #3

マージ済み
SlavekB が 1 個のコミットを feat/cmakeConv から master へマージ 5年前
Ghost5年前 にコメント

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost がラベル PR/rfc を追加 5年前
SlavekB が作業を開始 5年前
SlavekB が作業を終了 5年前
1h 55min 5s
SlavekB5年前 にコメント
オーナー

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB がタイトルを cmake conversion から WIP: cmake conversion に変更 5年前
SlavekB がラベル PR/wip を追加 5年前
SlavekB5年前 にコメント
オーナー

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB5年前 にコメント
オーナー

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB がタイトルを WIP: cmake conversion から cmake conversion に変更 5年前
SlavekB がラベル PR/wip を除去 5年前
SlavekB がプルリクエストをクローズ 5年前
SlavekB がラベル PR/rfc を除去 5年前
SlavekB がブランチ feat/cmakeConv を削除 5年前
SlavekB がマイルストーン R14.0.6 release に追加 5年前
プルリクエストは cdbb1c0a4c でマージされています。
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
担当者なし
2 人の参加者
通知
かかった時間の合計: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
期日

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: TDE/libtdeldap#3
読み込み中…
まだ内容がありません