cmake conversion #3

Sammanfogat
SlavekB sammanfogade 1 incheckningar från feat/cmakeConv in i master 5 år sedan
Ghost kommenterad 5 år sedan

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost added the PR/rfc label 5 år sedan
SlavekB började arbeta 5 år sedan
SlavekB slutade arbeta 5 år sedan
1h 55min 5s
SlavekB kommenterad 5 år sedan
Ägare

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB ändrade titeln från cmake conversion till WIP: cmake conversion 5 år sedan
SlavekB added the PR/wip label 5 år sedan
SlavekB kommenterad 5 år sedan
Ägare

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB kommenterad 5 år sedan
Ägare

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB ändrade titeln från WIP: cmake conversion till cmake conversion 5 år sedan
SlavekB removed the PR/wip label 5 år sedan
SlavekB closed this pull request 5 år sedan
SlavekB removed the PR/rfc label 5 år sedan
SlavekB tog bort grenen feat/cmakeConv 5 år sedan
SlavekB lade till denna till milstolpe R14.0.6 release 5 år sedan
Pull-förfrågan har sammanfogats som cdbb1c0a4c.
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
2 Deltagare
Notiser
Total Tid Spenderad: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
Förfallodatum

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: TDE/libtdeldap#3
Laddar…
Det finns inget innehåll än.