cmake conversion #3

Злито
SlavekB злито 1 комітів з feat/cmakeConv до master 5 роки тому
Ghost прокоментував(ла) 5 роки тому

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost додано PR/rfc з міткою 5 роки тому
SlavekB почав працювати 5 роки тому
SlavekB перестав(-ла) працювати 5 роки тому
1h 55min 5s
SlavekB прокоментував(ла) 5 роки тому
Власник

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB змінився заголовок з cmake conversion на WIP: cmake conversion 5 роки тому
SlavekB додано PR/wip з міткою 5 роки тому
SlavekB прокоментував(ла) 5 роки тому
Власник

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
SlavekB прокоментував(ла) 5 роки тому
Власник

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB змінився заголовок з WIP: cmake conversion на cmake conversion 5 роки тому
SlavekB видалено PR/wip з міткою 5 роки тому
SlavekB закрив цей запит на злиття 5 роки тому
SlavekB видалено PR/rfc з міткою 5 роки тому
SlavekB видалена гілка feat/cmakeConv 5 роки тому
SlavekB додав(ла) до R14.0.6 release етапу 5 роки тому
Запит на злиття був влитиий як cdbb1c0a4c.
Підпишіться щоб приєднатися до обговорення.
Немає рецензентів
Етап відсутній
Немає виконавця
2 учасників
Сповіщення
Загальний витрачений час: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
Дата завершення

Термін виконання не встановлений.

Залежності

No dependencies set.

Reference: TDE/libtdeldap#3
Завантаження…
Тут ще немає жодного змісту.