cmake conversion #3

已合併
SlavekB 5 年之前 將 1 次代碼提交從 feat/cmakeConv 合併至 master

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt.

I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.

The "doc" and "po" folder are actually empty, as a result I've left them commented in the CMakeLists.txt. I've added some options for the user to pass where It was marked as FIXME in src/libtdeldap.cpp.
Ghost added the PR/rfc label 5 年之前
SlavekB started working 5 年之前
SlavekB stopped working 5 年之前
1h 55min 5s
所有者

As expected, further work was needed.

  1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal.
  2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive.
  3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build.
  4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch.

Please test building on your system before I'll go ahead to merge.

As expected, further work was needed. 1. The Heimdal C API is used in the master branch; therefore, for Kerberos should be preferred Heimdal and we need to make sure that Kerberos is Heimdal. 2. To prevent portability issue, I added the detection whether the compiler supports the option -fpermissive. 3. The library version was 1.0.0 for Automake build, so I added the same version for CMake build. 4. Because there are big differences between the master branch and r14.0.x, there was a need for further work with the backport for the r14.0.x branch. Please test building on your system before I'll go ahead to merge.
SlavekB changed title from cmake conversion to WIP: cmake conversion 5 年之前
SlavekB added the PR/wip label 5 年之前
所有者

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap.

This is not compatible with hidden visibility. That's why we need more work to fix it.

Although libtdeldap is a library, in the libtdeldap.h header, no class is marked as exported. And some classes with the Private note are used in other applications – such as LDAPPamConfig in kcmldap. This is not compatible with hidden visibility. That's why we need more work to fix it.
所有者

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.

Thanks to commit 32c6b4398e is now possible to build libtdeldap with gcc hidden visibility.
SlavekB changed title from WIP: cmake conversion to cmake conversion 5 年之前
SlavekB removed the PR/wip label 5 年之前
SlavekB closed this pull request 5 年之前
SlavekB removed the PR/rfc label 5 年之前
SlavekB 刪除分支 feat/cmakeConv 5 年之前
SlavekB 新增至R14.0.6 release 里程碑 5 年之前
The pull request has been merged as cdbb1c0a4c.
登入 才能加入這對話。
No reviewers
未選擇里程碑
No Assignees
2 參與者
訊息
Total Time Spent: 1 hour 55 minutes
SlavekB
1 hour 55 minutes
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libtdeldap#3
Loading…
尚未有任何內容