qt -> tqt update. #1

Merged
MicheleC merged 1 commits from feat/tqt_update into master 6 years ago
Owner

In the original code there are number of qt entries which have not been changed to tqt. This is intentional.

In the original code there are number of qt entries which have not been changed to tqt. This is intentional.
MicheleC added this to the R14.1.0 release milestone 6 years ago
Owner

I believe that the url changes in Doxyfile can be forwarded to the upstream. Changes Qt => TQt in Doxyfile are not correct because we do not have qhelpgenerator.

The mention of Qt event loop in rfb/rfb.h is probably related to Qt, not TQt.

I believe that the url changes in Doxyfile can be forwarded to the upstream. Changes Qt => TQt in Doxyfile are not correct because we do not have qhelpgenerator. The mention of Qt event loop in rfb/rfb.h is probably related to Qt, not TQt.
Poster
Owner

I was a bit doubtious about the TQt rename of qhelpgenerator too. Then given they were comments I went ahead. Probably wiser to not rename, as you suggested. same thing needs to be adjusted also in admin module then.
The rename about qt event loop looks ok to me, since with TQt we have TQt event loop and no more Qt event loop 😉

I was a bit doubtious about the TQt rename of qhelpgenerator too. Then given they were comments I went ahead. Probably wiser to not rename, as you suggested. same thing needs to be adjusted also in admin module then. The rename about qt event loop looks ok to me, since with TQt we have TQt event loop and no more Qt event loop :wink:
Owner

The commit regarding the Qt event loop was included in 2010 - see 9f8d8d4e. At that time, the current version of the libvncserver was not in TDE, but the old local copy.

Replacing an old local copy of libvncserver in tdenetwork and TDE-related modifications - including TQEventLoop were in 2015 - see 366c7e7c. Therefore, I can say that the mentioned Qt event loop really has no connection with the TQt event loop 😉

The commit regarding the Qt event loop was included in 2010 - see 9f8d8d4e. At that time, the current version of the libvncserver was not in TDE, but the old local copy. Replacing an old local copy of libvncserver in tdenetwork and TDE-related modifications - including TQEventLoop were in 2015 - see 366c7e7c. Therefore, I can say that the mentioned Qt event loop really has no connection with the TQt event loop :wink:
Poster
Owner

Yes, your comment is correct. But if you look at the TDE code now, everything refers to TQtEventLoop. So IMO it is reasonable to assume that whatever code was added in the past for Qt event loop is now working with the TQt event loop.

Anyhow it is a small thing, I am ok with both renaming or not renaming 😄

Yes, your comment is correct. But if you look at the TDE code now, everything refers to TQtEventLoop. So IMO it is reasonable to assume that whatever code was added in the past for Qt event loop is now working with the TQt event loop. Anyhow it is a small thing, I am ok with both renaming or not renaming :smile:
MicheleC closed this pull request 6 years ago
MicheleC deleted branch feat/tqt_update 6 years ago
Poster
Owner

Merged and pushed upstream.

Merged and pushed upstream.
The pull request has been merged as 15a64bf9d5.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libtdevnc#1
Loading…
There is no content yet.