krfb: fix termination and syncing of threads on exit #10
Συγχωνευμένα
MicheleC
συγχώνευσε 1 υποβολές από fix/issue/3 σε master 6 μήνες πριν
Φόρτωση…
Αναφορά σε νέο ζήτημα
Δεν υπάρχει ακόμα περιεχόμενο.
Διαγραφή του Κλάδου 'fix/issue/3'
Η διαγραφή του κλάδου είναι μόνιμη. ΔΕΝ ΜΠΟΡΕΙ να αναιρεθεί. Συνέχεια;
This resolves issue #2 and replaces PR #4.
I can't test functionality here, so this is purely a logical-based patch.
Please help testing it and let me know how it goes.
04963912a8στοc1374295288 μήνες πρινc137429528στο200b89240f8 μήνες πρινkrfb: fix termination and syncing of threads on exit. This resolves issue #3.σε krfb: fix termination and syncing of threads on exit 8 μήνες πρινUnfortunately, this patch does not help solve the problem. Here is the error output - link.
Before these changes, the error output was like this - link.
ok, thanks for testing @ormorph. Will do more analysis on this and come back. Is there a simple way to test on a single machine? That would give me a way to reproduce the issue here.
krfb: fix termination and syncing of threads on exitσε WIP: krfb: fix termination and syncing of threads on exit 8 μήνες πρινGood news, I am able to reproduce the problem here, so I will now be able to test it myself.
This is good, I also tried it on one computer via virtualbox, it worked by creating a node adapter. Still, when you have a second computer with TDE, it is more convenient. But it is still possible to implement it.
200b89240fστοbc434b2a858 μήνες πρινbc434b2a85στο1a60e9b3008 μήνες πρινI have published an updated patch. Tested here and I don't have crashes anymore. I also verified the threads terminate successfully in a controlled manner.
@ormorph can you test this patch again on your side?
WIP: krfb: fix termination and syncing of threads on exitσε krfb: fix termination and syncing of threads on exit 8 μήνες πρινI didn't have any crashes, the patch works.
Thanks for testing @ormorph 🙂
Patch has been included in PSB and PTB repository for a long time for testing and no problems are reported. It seems to be time to merge it.
1a60e9b300στο90abc79efa6 μήνες πριν90abc79efaσε master 6 μήνες πρινΕξεταστές
90abc79efa.