krfb: fix termination and syncing of threads on exit #10

Συγχωνευμένα
MicheleC συγχώνευσε 1 υποβολές από fix/issue/3 σε master 6 μήνες πριν
Ιδιοκτήτης

This resolves issue #2 and replaces PR #4.
I can't test functionality here, so this is purely a logical-based patch.
Please help testing it and let me know how it goes.

This resolves issue #2 and replaces PR #4. I can't test functionality here, so this is purely a logical-based patch. Please help testing it and let me know how it goes.
MicheleC το πρόσθεσε στο R14.1.2 release ορόσημο 8 μήνες πριν
MicheleC πρόσθεσε 1 υποβολή 8 μήνες πριν
04963912a8
krfb: fix termination and syncing of threads on exit. This resolves issue #3.
MicheleC ζητήθηκε αναθεώρηση από Core 8 μήνες πριν
MicheleC ζητήθηκε αναθεώρηση από Owners 8 μήνες πριν
MicheleC force-pushed fix/issue/3 από το 04963912a8 στο c137429528 8 μήνες πριν
MicheleC force-pushed fix/issue/3 από το c137429528 στο 200b89240f 8 μήνες πριν
MicheleC άλλαξε το τίτλο από krfb: fix termination and syncing of threads on exit. This resolves issue #3. σε krfb: fix termination and syncing of threads on exit 8 μήνες πριν
Συνεργάτης

Unfortunately, this patch does not help solve the problem. Here is the error output - link.
Before these changes, the error output was like this - link.

Unfortunately, this patch does not help solve the problem. Here is the error output - [link](http://dpaste.com/FS85WE3DL). Before these changes, the error output was like this - [link](http://dpaste.com/9TM3V95TE).
Συντάκτης
Ιδιοκτήτης

ok, thanks for testing @ormorph. Will do more analysis on this and come back. Is there a simple way to test on a single machine? That would give me a way to reproduce the issue here.

ok, thanks for testing @ormorph. Will do more analysis on this and come back. Is there a simple way to test on a single machine? That would give me a way to reproduce the issue here.
MicheleC άλλαξε το τίτλο από krfb: fix termination and syncing of threads on exit σε WIP: krfb: fix termination and syncing of threads on exit 8 μήνες πριν
Συντάκτης
Ιδιοκτήτης

Good news, I am able to reproduce the problem here, so I will now be able to test it myself.

Good news, I am able to reproduce the problem here, so I will now be able to test it myself.
Συνεργάτης

Good news, I am able to reproduce the problem here, so I will now be able to test it myself.

This is good, I also tried it on one computer via virtualbox, it worked by creating a node adapter. Still, when you have a second computer with TDE, it is more convenient. But it is still possible to implement it.

> Good news, I am able to reproduce the problem here, so I will now be able to test it myself. This is good, I also tried it on one computer via virtualbox, it worked by creating a node adapter. Still, when you have a second computer with TDE, it is more convenient. But it is still possible to implement it.
MicheleC force-pushed fix/issue/3 από το 200b89240f στο bc434b2a85 8 μήνες πριν
MicheleC force-pushed fix/issue/3 από το bc434b2a85 στο 1a60e9b300 8 μήνες πριν
Συντάκτης
Ιδιοκτήτης

I have published an updated patch. Tested here and I don't have crashes anymore. I also verified the threads terminate successfully in a controlled manner.
@ormorph can you test this patch again on your side?

I have published an updated patch. Tested here and I don't have crashes anymore. I also verified the threads terminate successfully in a controlled manner. @ormorph can you test this patch again on your side?
MicheleC άλλαξε το τίτλο από WIP: krfb: fix termination and syncing of threads on exit σε krfb: fix termination and syncing of threads on exit 8 μήνες πριν
Συνεργάτης

have published an updated patch. Tested here and I don't have crashes anymore. I also verified the threads terminate successfully in a controlled manner.
@ormorph can you test this patch again on your side?

I didn't have any crashes, the patch works.

> have published an updated patch. Tested here and I don't have crashes anymore. I also verified the threads terminate successfully in a controlled manner. > @ormorph can you test this patch again on your side? I didn't have any crashes, the patch works.
Συντάκτης
Ιδιοκτήτης

Thanks for testing @ormorph 🙂

Thanks for testing @ormorph 🙂
SlavekB ενέκρινε αυτές τις αλλαγές 6 μήνες πριν
SlavekB άφησε ένα σχόλιο
Ιδιοκτήτης

Patch has been included in PSB and PTB repository for a long time for testing and no problems are reported. It seems to be time to merge it.

Patch has been included in PSB and PTB repository for a long time for testing and no problems are reported. It seems to be time to merge it.
MicheleC force-pushed fix/issue/3 από το 1a60e9b300 στο 90abc79efa 6 μήνες πριν
MicheleC συγχώνευσε την υποβολή 90abc79efa σε master 6 μήνες πριν
MicheleC διέγραψε το κλάδο fix/issue/3 6 μήνες πριν

Εξεταστές

SlavekB ενέκρινε αυτές τις αλλαγές 6 μήνες πριν
TDE/Core ζητήθηκε για αναθεώρηση 8 μήνες πριν
Το pull request έχει συγχωνευθεί ως 90abc79efa.
Συνδεθείτε για να συμμετάσχετε σε αυτή τη συνομιλία.
Δεν υπάρχουν εξεταστές
TDE/Core
Χωρίς Ορόσημο
Χωρίς Αποδέκτη
3 Συμμετέχοντες
Ειδοποιήσεις
Ημερομηνία Παράδοσης

Δεν ορίστηκε ημερομηνία παράδοσης.

Εξαρτήσεις

Δεν έχουν οριστεί εξαρτήσεις.

Αναφορά: TDE/libtdevnc#10
Φόρτωση…
Δεν υπάρχει ακόμα περιεχόμενο.