TDE
/
libtdevnc
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Fix 'true' definition. #5

Merged
MicheleC merged 1 commits from bugfix/43_ftbfs_pclinuxos_krfb into master 2 years ago
Conversation 6 Commits 1 Files Changed 1
Francois commented 2 years ago
Collaborator

This fixes issue TDE/tdenetwork#43.

Signed-off-by: François Andriot francois.andriot@libertysurf.fr

This fixes issue TDE/tdenetwork#43. Signed-off-by: François Andriot <francois.andriot@libertysurf.fr>
Francois added 1 commit 2 years ago
512fd4d832 Fix 'true' definition.
MicheleC merged commit 512fd4d832 into master 2 years ago
MicheleC deleted branch bugfix/43_ftbfs_pclinuxos_krfb 2 years ago
MicheleC added this to the R14.1.0 release milestone 2 years ago
MicheleC commented 2 years ago
Owner

Thanks, looks good.

Thanks, looks good.
obache commented 2 years ago
Collaborator

Why true and false must be defined here? not used directly, in C language scope whereas in C++ source code.

It seems true is defined before a system header try to define it, at least it's in bad place.

Why `true` and `false` must be defined here? not used directly, in C language scope whereas in C++ source code. It seems `true` is defined before a system header try to define it, at least it's in bad place.
MicheleC commented 2 years ago
Owner

yeah, good point Obata-san! We could just remove the complete #ifdef block around those lines.... I am currently testing it and will push a commit for it after a successful built.
Good catch and thanks for pointing this out!

yeah, good point Obata-san! We could just remove the complete #ifdef block around those lines.... I am currently testing it and will push a commit for it after a successful built. Good catch and thanks for pointing this out!
MicheleC commented 2 years ago
Owner

I have removed those definitions both in master and r14.0.x branch.
I tested a successful build in master, but not in r14.0.x.
@Francois could you verify everything is good on your hand on r14.0.x?

I have removed those definitions both in master and r14.0.x branch. I tested a successful build in master, but not in r14.0.x. @Francois could you verify everything is good on your hand on r14.0.x?
Francois commented 2 years ago
Poster
Collaborator

Hello, I confirm that removing the definition entirely works OK.

Hello, I confirm that removing the definition entirely works OK.
MicheleC commented 2 years ago
Owner

Thanks for the feedback @Francois.

Thanks for the feedback @Francois.
The pull request has been merged as 512fd4d832.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/libtdevnc#5
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bugfix/43_ftbfs_pclinuxos_krfb'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes