cmake conversion #1

已合并
SlavekB 5 年前 将 1 次代码提交从 feat/cmakeConv 合并至 master
Ghost 评论于 5 年前

mplayerthumbsconfig ( small gui to set mplayer path) is supposed to build with videopreview as a module/plugin (videopreview.so) but couldn't manage to build It that way, therefore I build videopreview both as a module and a static library, then mplayerthumbsconfig is linked with the static lib.

videopreview.so is still provided as a module for other apps to use (which one?).

There is no po files at the moment.

Strips over thumbnails is enabled by default with automake, since we usually build with all options, I've set It up with ${WITH_ALL_OPTIONS}, Slavek, if you prefer that option set "on" or "off" by default, just tell me, I'll change It.

mplayerthumbsconfig ( small gui to set mplayer path) is supposed to build with videopreview as a module/plugin (videopreview.so) but couldn't manage to build It that way, therefore I build videopreview both as a module and a static library, then mplayerthumbsconfig is linked with the static lib. videopreview.so is still provided as a module for other apps to use (which one?). There is no po files at the moment. Strips over thumbnails is enabled by default with automake, since we usually build with all options, I've set It up with ${WITH_ALL_OPTIONS}, Slavek, if you prefer that option set "on" or "off" by default, just tell me, I'll change It.
Ghost5 年前 添加了标签 PR/rfc
Ghost 评论于 5 年前
发布者

On the 2014-03-01 Darell reported bug 1986 related to mplayerthumbsconfig and videopreview as a shared lib by the way.

On the 2014-03-01 Darell reported bug 1986 related to mplayerthumbsconfig and videopreview as a shared lib by the way.
SlavekB 评论于 5 年前
所有者

Because there were more changes, I made an amend to your commit instead of review:

  1. The entire part with the add_custom_command and set_source_files_properties for mplayerthumbs.kcfgc was ineffective.
    Since mplayerthumbs.kcfgc is not a source file for object compilation (such as cpp=>o), set_source_files_properties has no effect on such a file and therefore custom command has never been executed.
  2. Since mplayerthumbs.kcfgc was listed as the source for two libraries, it was actually processed 2×. If the previous custom command would work, it would be processed 3×.
  3. Linking the module to the binary when building with automake was odd. You fixed it using a static library, but there is no need for a whole videopreview library.
    I modified the code so that the static mplayerthumbscfg library is now used, which is linked to both the module and the binary. As a result, mplayerthumbs.kcfgc is processed once.
  4. Instead of set_source_files_properties, I used set_property( SOURCE ) because this allows APPEND.
    You can wonder why I set mplayerthumbs.cpp as dependence instead of mplayerthumbs.h – that's because of an bug in KDE3_ADD_KCFG_FILES, which as OUTPUT sets only a cpp file and does not list the header.
  5. Because there is a translation template and a component is defined in TDE Weblate, PO files can be created automatically from TDE Weblate. Therefore, we need to have rules for building translations even though there are no PO files now.
Because there were more changes, I made an amend to your commit instead of review: 1. The entire part with the `add_custom_command` and `set_source_files_properties` for `mplayerthumbs.kcfgc` was ineffective.<br/>Since `mplayerthumbs.kcfgc` is not a source file for object compilation (such as cpp=>o), `set_source_files_properties` has no effect on such a file and therefore custom command has never been executed. 2. Since `mplayerthumbs.kcfgc` was listed as the source for two libraries, it was actually processed 2×. If the previous custom command would work, it would be processed 3×. 3. Linking the module to the binary when building with automake was odd. You fixed it using a static library, but there is no need for a whole `videopreview` library.<br/>I modified the code so that the static `mplayerthumbscfg` library is now used, which is linked to both the module and the binary. As a result, `mplayerthumbs.kcfgc` is processed once. 4. Instead of `set_source_files_properties`, I used `set_property( SOURCE )` because this allows `APPEND`.<br/>You can wonder why I set mplayerthumbs.cpp as dependence instead of mplayerthumbs.h – that's because of an bug in `KDE3_ADD_KCFG_FILES`, which as `OUTPUT` sets only a cpp file and does not list the header. 5. Because there is a translation template and a component is defined in TDE Weblate, PO files can be created automatically from TDE Weblate. Therefore, we need to have rules for building translations even though there are no PO files now.
SlavekB5 年前 关闭此合并请求
SlavekB5 年前 删除了分支 feat/cmakeConv
SlavekB5 年前 删除了标签 PR/rfc
SlavekB5 年前 添加了里程碑 R14.0.6 release
该合并请求已作为 a4a23a811f 被合并。
登录 并参与到对话中。
无审核者
未选择里程碑
未指派成员
2 名参与者
通知
到期时间

未设置到期时间。

依赖工单

没有设置依赖项。

参考:TDE/mplayerthumbs#1
正在加载...
这个人很懒,什么都没留下。