TDE
/
potracegui
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

conversion to cmake #1

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 5 years ago
Conversation 0 Commits 1 Files Changed 1
Ghost commented 5 years ago

I've added a man page taken from your Debian packaging system.
I've also added the new 'po stuff' but since It's not clear to me how It works, I'm not sure if It was the proper way to do It..

I've added a man page taken from your Debian packaging system. I've also added the new 'po stuff' but since It's not clear to me how It works, I'm not sure if It was the proper way to do It..
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

It seems that this application does not need any special stuff to generate a translation template, so you created the CMakeL10n rules correctly. Thank you.

Please adjust the linker flags settings, as noted in the review.

It seems that this application does not need any special stuff to generate a translation template, so you created the CMakeL10n rules correctly. Thank you. Please adjust the linker flags settings, as noted in the review.
CMakeLists.txt Outdated
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TQT_CXX_FLAGS}" )
set( CMAKE_SHARED_LINKER_FLAGS "-Wl,--no-undefined" )
set( CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined" )
SlavekB commented 5 years ago
Owner

Please adjust settings of linkers flags in the sense of the recent series of PR – see TDE/tdelibs#10.

Please adjust settings of linkers flags in the sense of the recent series of PR – see TDE/tdelibs#10.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeConv 5 years ago
SlavekB added this to the R14.0.6 release milestone 5 years ago
The pull request has been merged as 33d1bb0500.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/potracegui#1
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeConv'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes