TDE
/
pytdeextensions
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Drop Python 2 support – part 2 #8

Merged
SlavekB merged 3 commits from feat/drop-python2-part2 into master 1 year ago
Conversation 0 Commits 3 Files Changed 2
SlavekB commented 1 year ago
Owner

Here are a few parts:

  1. tdedistutils.py is installed within a binary package and therefore from src import qtuicompiler is undesirable.
  2. When using tdedistutils.py, a Makefile is generated, so there we also need to use sys.abiflags to link the Python 3 library.
  3. When using tdedistutils.py, C++ files are generated where PyString_FromString was used, which is intended for Python 2, while for Python 3 we need to use PyBytes_FromString.
Here are a few parts: 1. `tdedistutils.py` is installed within a binary package and therefore `from src import qtuicompiler` is undesirable. 2. When using `tdedistutils.py`, a Makefile is generated, so there we also need to use `sys.abiflags` to link the Python 3 library. 3. When using `tdedistutils.py`, C++ files are generated where `PyString_FromString` was used, which is intended for Python 2, while for Python 3 we need to use `PyBytes_FromString`.
SlavekB added 3 commits 1 year ago
2561016208
Fix import of qtuicompiler in tdedistutils.py.
c329b93083
Drop python2 support in code generated from tdedistutils.py.
SlavekB added this to the R14.1.0 release milestone 1 year ago
SlavekB requested review from MicheleC 1 year ago
SlavekB added a new dependency 1 year ago
TDE/tde-guidance#8 - Drop python2 support.
SlavekB force-pushed feat/drop-python2-part2 from c329b93083 to cc5852b1e4 1 year ago
MicheleC approved these changes 1 year ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB merged commit cc5852b1e4 into master 1 year ago
SlavekB deleted branch feat/drop-python2-part2 1 year ago

Reviewers

MicheleC approved these changes 1 year ago
The pull request has been merged as cc5852b1e4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Blocks
#8 Drop python2 support.
TDE/tde-guidance
Reference: TDE/pytdeextensions#8
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/drop-python2-part2'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes