TDE
/
pytqt
6
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity
Labels Milestones

WIP:relate to bug request 2699, rename the python-tqt libs to avoid conflicts with upstream. #4

Closed
Ghost wants to merge 1 commits from fix/bug2699 into master
Conversation 1 Commits 1 Files Changed 4
Ghost commented 2 years ago

need TDE/sip4-tqt#2

need https://mirror.git.trinitydesktop.org/gitea/TDE/sip4-tqt/pulls/2
Ghost added the PR/wip label 2 years ago
Ghost added 1 commit 2 years ago
MicheleC reviewed 2 years ago
build.py
# Get the SIP configuration.
try:
from sip4_tqt import sipconfig
import siptrinityconfig
MicheleC commented 2 years ago
Owner

Maybe I am saying something wrong because I am not up to speed with all the discussion, but wouldn't be easier to have something like:

from siptrinityconfig import sipconfig

or even better:

from sip_trinity_config import sipconfig
Maybe I am saying something wrong because I am not up to speed with all the discussion, but wouldn't be easier to have something like: ``` from siptrinityconfig import sipconfig ``` or even better: ``` from sip_trinity_config import sipconfig ```
Ghost commented 2 years ago
Poster

Slavek wanted those two Python modules renamed to put them in the main Python directory.

Either you rename them, then you load them as:

import whatevername

or you use a subfolder like:

from mysubfolder import sipconfig
Slavek wanted those two Python modules renamed to put them in the main Python directory. Either you rename them, then you load them as: ``` import whatevername ``` or you use a subfolder like: ``` from mysubfolder import sipconfig ```
MicheleC commented 2 years ago
Owner

Uhm... as long as my understanding of python goes, the from-import clause work as

from <module name> import <object>

So

from sip_trinity_config import sipconfig

would look for the sip_trinity_config (renamed as asked by Slavek) and load the sipconfig from there.

Uhm... as long as my understanding of python goes, the from-import clause work as ``` from <module name> import <object> ``` So ``` from sip_trinity_config import sipconfig ``` would look for the sip_trinity_config (renamed as asked by Slavek) and load the sipconfig from there.
MicheleC reviewed 2 years ago
build.py
import siptrinityconfig
except:
print "Unable to import the sipconfig module. Please make sure you have"
print "Unable to import the siptrinityconfig module. Please make sure you have"
MicheleC commented 2 years ago
Owner

And

print "Unable to import the sipconfig from siptrinityconfig module.  Please make sure you have"
And ``` print "Unable to import the sipconfig from siptrinityconfig module. Please make sure you have" ```
Ghost commented 2 years ago
Poster

WIP, all the reference in the doc for sip and python-tqt have to be adjusted as well.

WIP, all the reference in the doc for sip and python-tqt have to be adjusted as well.
Ghost commented 2 years ago
Poster

This work won't go anywhere, PR is closed.

This work won't go anywhere, PR is closed.
Ghost closed this pull request 2 years ago
Ghost deleted branch fix/bug2699 2 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/pytqt#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/bug2699'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes