WIP:relate to bug request 2699, rename the python-tqt libs to avoid conflicts with upstream. #4

Closed
cethyel wants to merge 1 commits from fix/bug2699 into master
cethyel commented 2 months ago
Collaborator
need https://mirror.git.trinitydesktop.org/gitea/TDE/sip4-tqt/pulls/2
cethyel added the
PR/wip
label 2 months ago
cethyel added 1 commit 2 months ago
MicheleC reviewed 2 months ago
# Get the SIP configuration.
try:
from sip4_tqt import sipconfig
import siptrinityconfig
Poster
Owner

Maybe I am saying something wrong because I am not up to speed with all the discussion, but wouldn't be easier to have something like:

from siptrinityconfig import sipconfig

or even better:

from sip_trinity_config import sipconfig
Maybe I am saying something wrong because I am not up to speed with all the discussion, but wouldn't be easier to have something like: ``` from siptrinityconfig import sipconfig ``` or even better: ``` from sip_trinity_config import sipconfig ```
Poster
Collaborator

Slavek wanted those two Python modules renamed to put them in the main Python directory.

Either you rename them, then you load them as:

import whatevername

or you use a subfolder like:

from mysubfolder import sipconfig
Slavek wanted those two Python modules renamed to put them in the main Python directory. Either you rename them, then you load them as: ``` import whatevername ``` or you use a subfolder like: ``` from mysubfolder import sipconfig ```
Poster
Owner

Uhm... as long as my understanding of python goes, the from-import clause work as

from <module name> import <object>

So

from sip_trinity_config import sipconfig

would look for the sip_trinity_config (renamed as asked by Slavek) and load the sipconfig from there.

Uhm... as long as my understanding of python goes, the from-import clause work as ``` from <module name> import <object> ``` So ``` from sip_trinity_config import sipconfig ``` would look for the sip_trinity_config (renamed as asked by Slavek) and load the sipconfig from there.
MicheleC reviewed 2 months ago
import siptrinityconfig
except:
print "Unable to import the sipconfig module. Please make sure you have"
print "Unable to import the siptrinityconfig module. Please make sure you have"
Poster
Owner

And

print "Unable to import the sipconfig from siptrinityconfig module.  Please make sure you have"
And ``` print "Unable to import the sipconfig from siptrinityconfig module. Please make sure you have" ```
Poster
Collaborator

WIP, all the reference in the doc for sip and python-tqt have to be adjusted as well.

WIP, all the reference in the doc for sip and python-tqt have to be adjusted as well.
Poster
Collaborator

This work won't go anywhere, PR is closed.

This work won't go anywhere, PR is closed.
cethyel closed this pull request 2 months ago
cethyel deleted branch fix/bug2699 2 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.