Conversion to the cmake building system. #2

Merged
SlavekB merged 2 commits from feat/cmakeConv into master 3 years ago
Ghost commented 3 years ago

Made out of boredness on Holidays...

One can note that this package does rely on the the usual lib from TDE and libqalculate only, I didn't see the need for libcln or xml, etc.

The daily currency exchange xml file is corectly downloaded by the application through the libqalculate library but I'm not sure this file is actually used by the application (didn't try every features though).

Made out of boredness on Holidays... One can note that this package does rely on the the usual lib from TDE and libqalculate only, I didn't see the need for libcln or xml, etc. The daily currency exchange xml file is corectly downloaded by the application through the libqalculate library but I'm not sure this file is actually used by the application (didn't try every features though).
Ghost added 1 commit 3 years ago
455906cff6
Conversion to the cmake building system.
Ghost force-pushed feat/cmakeConv from 455906cff6 to 700efd2c34 3 years ago
SlavekB added 2 commits 3 years ago
026bf9105e
CMake: Use tde_add_project_translations common macro.
408f2904bb
Added controlled conversions to char* instead of automatic ascii conversions.
Owner

Although translations are not in new layout, there is still possible to use common macro tde_add_project_translations(). See added commit that you can squash to your CMake conversion.

Furthermore, I added the usual commit for ASCII cast.

Please, you can test whether everything is fine on your system.

Although translations are not in new layout, there is still possible to use common macro `tde_add_project_translations()`. See added commit that you can squash to your CMake conversion. Furthermore, I added the usual commit for ASCII cast. Please, you can test whether everything is fine on your system.
Ghost force-pushed feat/cmakeConv from 408f2904bb to c9792a21ad 3 years ago
Ghost commented 3 years ago
Poster

Should be good to go, I had made It on Ubuntu but I have rebuilt today on Slackware, no problem whatsoever came up.

Should be good to go, I had made It on Ubuntu but I have rebuilt today on Slackware, no problem whatsoever came up.
SlavekB merged commit c9792a21ad into master 3 years ago
SlavekB deleted branch feat/cmakeConv 3 years ago
SlavekB added this to the R14.0.11 release milestone 3 years ago
Owner

When building for all distributions I encountered a problem on Ubuntu 18.04 (Bionic) because libqalculate.pc does not refer to link the CLN library and therefore FTBFS occurs. It seems that for fix bug in libqalculate 0.9.10 we will need to add checking if we need to explicitly add linking CLN.

When building for all distributions I encountered a problem on Ubuntu 18.04 (Bionic) because `libqalculate.pc` does not refer to link the CLN library and therefore FTBFS occurs. It seems that for fix bug in libqalculate 0.9.10 we will need to add checking if we need to explicitly add linking CLN.
The pull request has been merged as c9792a21ad.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/qalculate-tde#2
Loading…
There is no content yet.