Entry step for renaming PyTQt module libraries from qt* to tqt*. #10
Merged
SlavekB
merged 2 commits from feat/rename-pytqt-module-libraries-qt-tqt into master 1 year ago
No Label
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
Reference: TDE/sip4-tqt#10
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/rename-pytqt-module-libraries-qt-tqt'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Although SIP-TQt is built before PyTQt and is not directly dependent on TQt and PyTQt, it contains parts closely related to PyTQt and the resulting python modules that PyTQt builds. Therefore, PyTQt related renames must start in SIP-TQt.
78dfb1c3c3todd04b94de81 year agoPR looks good, just a couple of things to adjust.
I have yet to build and do a functionality test of the equivalent pytqt's PR
version number anyway.</p><p>For example:</p><div class="highlight-python"><pre>%Module qt 5</pre><div class="highlight-python"><pre>%Module tqt 5</pre>There is no TQt 5 :-)
The version here is not related to the version of the TQt library as such, but to determine the version of the SIP module. As you can see in TDE/pytqt, for qtmod.sip there is:
%Module PyTQt.qt 2. Most modules have version 1, but for example PyTQt.qtxml is version 0 and PyTQt.qtext is version 4.Ok, then ignore my comment.
const char *type_suffix;type_suffix = (pluginPyQt4(pt) || pluginPyTQt3(pt)) ? ".super" : "";type_suffix = (pluginPyQt4(pt) || pluginPyTQt(pt)) ? ".super" : "";I guess we can get rid of
pluginPyQt4overall.Yes, sure. The Qt4 related parts have already been removed in #5, but apparently there are some other parts suitable for removal. Thank you for notifying it.
Looks good.
ffc7f9360ctod768e913791 year agod768e91379into master 1 year agoReviewers
d768e91379.