TDE
/
smartcardauth
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

conversion to the cmake building system #1

Merged
Ghost merged 1 commits from feat/cmakeConv into master 5 years ago
Conversation 1 Commits 1 Files Changed 7
Ghost commented 5 years ago

This app hasn't been tested beyond the build itself.

This app hasn't been tested beyond the build itself.
Ghost added this to the R14.1.0 release milestone 5 years ago
Ghost added the PR/rfc label 5 years ago
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

There is one small comment, otherwise it looks good.

There is one small comment, otherwise it looks good.
ConfigureChecks.cmake Outdated
# required stuff
find_package( TQt )
find_package( TDE )
SlavekB commented 5 years ago
Owner

Because smartcardauth is a program for a system that is independent of TQt and TDE, it is useless to detect them.

Because smartcardauth is a program for a system that is independent of TQt and TDE, it is useless to detect them.
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

Thank you for your previous edits. Here is one more question.

Thank you for your previous edits. Here is one more question.
ConfigureChecks.cmake Outdated
pkg_search_module( SSL openssl )
if( NOT SSL_FOUND )
tde_message_fatal( "OpenSSL is required but was not found on your system" )
SlavekB commented 5 years ago
Owner

On some systems, SSL may be installed but without the pkg-config file. Therefore, for example, in tdelibs it is more complex detection: tdelibs/CMakeLists.txt Should we add such detection here?

On some systems, SSL may be installed but without the pkg-config file. Therefore, for example, in tdelibs it is more complex detection: [tdelibs/CMakeLists.txt](../tdelibs/src/branch/master/CMakeLists.txt#L1031) Should we add such detection here?
Ghost commented 5 years ago
Poster

Should we add such detection here?

ok, I'll add that.

>Should we add such detection here? ok, I'll add that.
Ghost removed the PR/rfc label 5 years ago
Ghost closed this pull request 5 years ago
Ghost deleted branch feat/cmakeConv 5 years ago
The pull request has been merged as 693098407f.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/smartcardauth#1
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeConv'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes