TDE
/
smartcardauth
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Conversion to the cmake building system (r14.0.x) #2

Merged
SlavekB merged 1 commits from feat/cmakeConv-r14.0.x into r14.0.x 5 years ago
Conversation 0 Commits 1 Files Changed 2
SlavekB commented 5 years ago
Owner

Because smartcardauth differs significantly between master and r14.0.x branch, it is not possible to make cherry-pick of #1 into r14.0.x branch. To allow a change to CMake for both branches, I prepared separate patches for r14.0.x branch.

To solve the problem with automatic ascii cast from TQString, there is a patch that removes tons of conversions TQString => char* => TQString that were in the existing code.

Because smartcardauth differs significantly between master and r14.0.x branch, it is not possible to make cherry-pick of #1 into r14.0.x branch. To allow a change to CMake for both branches, I prepared separate patches for r14.0.x branch. To solve the problem with automatic ascii cast from TQString, there is a patch that removes tons of conversions TQString => char* => TQString that were in the existing code.
SlavekB added this to the R14.0.7 release milestone 5 years ago
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/cmakeConv-r14.0.x 5 years ago
The pull request has been merged as fa96f7798a.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/smartcardauth#2
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeConv-r14.0.x'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes