Labels Milestones

openssl11 fixes / updates for modern Linux #3

Manually merged

MicheleC merged 1 commits from openssl11_fixes into master 4 years ago

Conversation 4 Commits 1 Files Changed 1

tpearson commented 4 years ago

Owner

Verified to work on Debian Buster / ppc64le

Verified to work on Debian Buster / ppc64le

MicheleC commented 4 years ago

Owner

Hi Tim, nice to see you here 😄

Could you sign off your commits with -s and update the PR? You can git force on the same branch, since after we merge to master we usually delete the branch anyway.

EDIT: if you wish you can register your public key on TGW as well and sign the commits too, so your commits with appear "green with lock" when looking at them. Not a strict requirement of course, just nice to do 😉

Hi Tim, nice to see you here :smile:<br/> Could you sign off your commits with -s and update the PR? You can git force on the same branch, since after we merge to master we usually delete the branch anyway. EDIT: if you wish you can register your public key on TGW as well and sign the commits too, so your commits with appear "green with lock" when looking at them. Not a strict requirement of course, just nice to do :wink:

MicheleC commented 4 years ago

Owner

Thanks Tim! 😄

Thanks Tim! :smile:

SlavekB commented 4 years ago

Owner

I added #ifdef to re-enable compatibility with OpenSSL < 1.1 and hope to LibreSSL as well.

Edit: Tested on Jessie.

Edit1: Tested on Bullseye where it was necessary to add pkg-config to build-deps.

I added `#ifdef` to re-enable compatibility with OpenSSL < 1.1 and hope to LibreSSL as well. Edit: Tested on Jessie. Edit1: Tested on Bullseye where it was necessary to add pkg-config to build-deps.

MicheleC commented 4 years ago

Owner

I added a small commit that refactors the code, getting rid of one #ifdef block and unifying the syntax of the other 3 #ifdef, similar to what was done for tdelibs as well.

I added a small commit that refactors the code, getting rid of one #ifdef block and unifying the syntax of the other 3 #ifdef, similar to what was done for tdelibs as well.

MicheleC closed this pull request 4 years ago

SlavekB deleted branch openssl11_fixes 4 years ago

SlavekB added this to the R14.1.0 release milestone 4 years ago

The pull request has been manually merged as 6d6ab7d7ae.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.1.0 release

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/smartcardauth#3

Write Preview

Loading…

Cancel

Save

There is no content yet.