TDE
/
smb4k
6
0
Fork 0
Code Issues 1 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

Build issue: FTBFS on CentOS 7 #18

Closed
opened 3 weeks ago by Francois · 8 comments
Francois commented 3 weeks ago
Collaborator

Basic information

  • TDE version: 14.1.2
  • Distribution: CentOS 7
  • Hardware: amd64

Description

Cannot build smb4k en CentOS7. Another 'gcc is too old' issue ?

Steps to reproduce

Build

Screenshots

See attached log file.

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: 14.1.2 - Distribution: CentOS 7 - Hardware: amd64 <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description Cannot build smb4k en CentOS7. Another 'gcc is too old' issue ? ## Steps to reproduce Build ## Screenshots See attached log file.
smb4k-centos7-ftbfs.log
23 KiB
Francois added the SL/critical label 3 weeks ago
MicheleC commented 3 weeks ago
Owner

This could actually be a code mistake. Can you try if this works: change `smb4tdeglobal.h line 46 as follow:

namespace Smb4TDEGlobal KDE_EXPORT

If it works, I will later make an official PR for that.

This could actually be a code mistake. Can you try if this works: change `smb4tdeglobal.h line 46 as follow: ``` namespace Smb4TDEGlobal KDE_EXPORT ``` If it works, I will later make an official PR for that.
SlavekB commented 3 weeks ago
Owner

Please, you can try to move KDE_EXPORT before namespace - ie:

KDE_EXPORT namespace Smb4TDEGlobal
Please, you can try to move `KDE_EXPORT` before `namespace` - ie: ``` KDE_EXPORT namespace Smb4TDEGlobal ```
SlavekB commented 3 weeks ago
Owner

Note: This may be also the case where it is class KDE_EXPORT – you can try to switch it to KDE_EXPORT class.

Note: This may be also the case where it is `class KDE_EXPORT` – you can try to switch it to `KDE_EXPORT class`.
Francois commented 3 weeks ago
Poster
Collaborator

Please, you can try to move KDE_EXPORT before namespace - ie:

KDE_EXPORT namespace Smb4TDEGlobal

This one gives:

[ 13%] Building CXX object smb4k/core/CMakeFiles/smb4kcore-shared.dir/smb4kbookmarkhandler.cpp.o
cd "/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build/smb4k/core" && /usr/lib64/ccache/c++  -Dsmb4kcore_shared_EXPORTS -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k" -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build/smb4k" -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build" -I/usr/include/tqt3 -I/usr/include/tqt -I/opt/trinity/include/tde -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core" -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build/smb4k/core"  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches   -m64 -mtune=generic -fdebug-prefix-map=/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610=.  -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/usr/include/tqt3 -I/usr/include/tqt -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -DNDEBUG -fPIC   -std=gnu++11 -o CMakeFiles/smb4kcore-shared.dir/smb4kbookmarkhandler.cpp.o -c "/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp"
In file included from /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:43:0:
/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4tdeglobal.h:46:12: error: expected unqualified-id before 'namespace'
 KDE_EXPORT namespace Smb4TDEGlobal
            ^
/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:47:17: error: 'Smb4TDEGlobal' is not a namespace-name
 using namespace Smb4TDEGlobal;
                 ^
/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:47:30: error: expected namespace-name before ';' token
 using namespace Smb4TDEGlobal;
                              ^
/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp: In member function 'void Smb4KBookmarkHandler::addBookmark(Smb4KBookmark*)':
/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:99:112: error: 'specifyUser' was not declared in this scope
     TQString share = specifyUser( bookmark->host(), kapp->mainWidget() ? kapp->mainWidget() : 0, "SpecifyUser" );
                                                                                                                ^
make[2]: *** [smb4k/core/CMakeFiles/smb4kcore-shared.dir/smb4kbookmarkhandler.cpp.o] Error 1
> Please, you can try to move `KDE_EXPORT` before `namespace` - ie: > ``` > KDE_EXPORT namespace Smb4TDEGlobal > ``` > This one gives: ``` [ 13%] Building CXX object smb4k/core/CMakeFiles/smb4kcore-shared.dir/smb4kbookmarkhandler.cpp.o cd "/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build/smb4k/core" && /usr/lib64/ccache/c++ -Dsmb4kcore_shared_EXPORTS -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k" -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build/smb4k" -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build" -I/usr/include/tqt3 -I/usr/include/tqt -I/opt/trinity/include/tde -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core" -I"/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/build/smb4k/core" -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fdebug-prefix-map=/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610=. -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/usr/include/tqt3 -I/usr/include/tqt -DTQT_NO_ASCII_CAST -DTQT_NO_STL -DTQT_NO_COMPAT -DTQT_NO_TRANSLATION -DTQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -DNDEBUG -fPIC -std=gnu++11 -o CMakeFiles/smb4kcore-shared.dir/smb4kbookmarkhandler.cpp.o -c "/tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp" In file included from /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:43:0: /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4tdeglobal.h:46:12: error: expected unqualified-id before 'namespace' KDE_EXPORT namespace Smb4TDEGlobal ^ /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:47:17: error: 'Smb4TDEGlobal' is not a namespace-name using namespace Smb4TDEGlobal; ^ /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:47:30: error: expected namespace-name before ';' token using namespace Smb4TDEGlobal; ^ /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp: In member function 'void Smb4KBookmarkHandler::addBookmark(Smb4KBookmark*)': /tmp/BUILD.el7.x86_64/trinity-smb4k-14.1.2~pre15+9ee91610/smb4k/core/smb4kbookmarkhandler.cpp:99:112: error: 'specifyUser' was not declared in this scope TQString share = specifyUser( bookmark->host(), kapp->mainWidget() ? kapp->mainWidget() : 0, "SpecifyUser" ); ^ make[2]: *** [smb4k/core/CMakeFiles/smb4kcore-shared.dir/smb4kbookmarkhandler.cpp.o] Error 1 ```
Francois commented 3 weeks ago
Poster
Collaborator

This could actually be a code mistake. Can you try if this works: change `smb4tdeglobal.h line 46 as follow:

namespace Smb4TDEGlobal KDE_EXPORT

If it works, I will later make an official PR for that.

This one has fixed the issue. Thanks !

> This could actually be a code mistake. Can you try if this works: change `smb4tdeglobal.h line 46 as follow: > ``` > namespace Smb4TDEGlobal KDE_EXPORT > ``` > > If it works, I will later make an official PR for that. This one has fixed the issue. Thanks !
MicheleC commented 3 weeks ago
Owner

This one has fixed the issue. Thanks !

Ok, will prepare proper PR later or tomorrow morning.

> This one has fixed the issue. Thanks ! Ok, will prepare proper PR later or tomorrow morning.
MicheleC commented 3 weeks ago
Owner

See PR #19.

See PR #19.
MicheleC added this to the R14.1.2 release milestone 3 weeks ago
MicheleC commented 3 weeks ago
Owner

PR merged.

PR merged.
MicheleC closed this issue 3 weeks ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
r14.0.x
v3.5.13-sru
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/smb4k#18
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes