Replaced USE_SOLARIS definition with __sun. #4
Merged
MicheleC
merged 1 commits from feat/solaris
into master
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/solaris'
Deleting a branch is permanent. It CANNOT be undone. Continue?
As per title.
Removal of USE_SOLARIS from autotools files will be done at a later stage, after replacement of USE_SOLARIS has been done throughout all TDE code.
@obache could you check/test whether this PR looks good? For following packages I can do similar replacements but for the first one I would like to have your feedback (relates to TDE/tde#74).
What about the
__solaris__
define? Is that ok or should that be removed too?I don't know about
__solaris__
, but neither GCC nor Oracle Solaris Studio cc define the macro now.For smb4k/core/smb4kmounter.cpp, It should be replaced with
__sun
too, because it is used below alone, not withUSE_SOLARIS
.Ok, thanks for the feedback. I will update the PR later tonight and push an update.
863a27ccc0
to497297648c
2 years ago@obache I pushed an updated version of the commit. Please let me know what you think.
Although I don't have the opportunity to test it on Solaris, it looks right.
Thanks @SlavekB, I will wait for Obata-san to feedback before merging.
looks good.
(accidentally refused to review)
497297648c
into master 2 years agoThanks Obata-san. I will made similar changes for the other modules in coming days without creating PRs, unless I need to ask for some reasons.
Reviewers
497297648c
.