TDE
/
tde-cmake
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

tde_add_library: Link embedded libraries as PRIVATE. #87

Merged
SlavekB merged 1 commits from feat/tde_add_library-link-embed-as-private into master 1 year ago
Conversation 0 Commits 1 Files Changed 1
SlavekB commented 1 year ago
Owner

Since the embedded libraries are fully contained in the resulting library, there seems to be a good reason for them to be listed as linked private.

In order to maintain the embedded libraries are the first in the list, and at the same time to use a single PRIVATE and PUBLIC, all the private linked libraries are now listed among the first.

Since the embedded libraries are fully contained in the resulting library, there seems to be a good reason for them to be listed as linked private. In order to maintain the embedded libraries are the first in the list, and at the same time to use a single `PRIVATE` and `PUBLIC`, all the private linked libraries are now listed among the first.
SlavekB added 1 commit 1 year ago
25734cf506
tde_add_library: Link embedded libraries as PRIVATE.
MicheleC approved these changes 1 year ago
MicheleC left a comment
Owner

Looks good

Looks good
SlavekB merged commit 25734cf506 into master 1 year ago
SlavekB deleted branch feat/tde_add_library-link-embed-as-private 1 year ago
SlavekB added this to the R14.1.0 release milestone 1 year ago

Reviewers

MicheleC approved these changes 1 year ago
The pull request has been merged as 25734cf506.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-cmake#87
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/tde_add_library-link-embed-as-private'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes