TDE
/
tde-common-admin
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

doxygen: Determine the module name from the information in .tdescminfo #10

Merged
SlavekB merged 1 commits from fix/doxygen-module-name into master 3 years ago
Conversation 0 Commits 1 Files Changed 1
SlavekB commented 3 years ago
Owner

Although it's a bit awkward, due to the admin module, CMake building may fail. If the top source directory is not named according to the module name (for example, test-build instead of tdelibs-<something>), the wrong folder name is used when generating apidox – instead of .../share/doc/tde/HTML/en/tdelibs-apidocs is used .../share/doc/tde/HTML/test-build-apidocs. This was the reason why building packages failed when testing with the reprotest tool.

Because it is not possible to use the CMake project name in the admin module, the patch tries to get the correct name in the .tdescminfo file.

Although it's a bit awkward, due to the admin module, CMake building may fail. If the top source directory is not named according to the module name (for example, `test-build` instead of `tdelibs-<something>`), the wrong folder name is used when generating apidox – instead of `.../share/doc/tde/HTML/en/tdelibs-apidocs` is used `.../share/doc/tde/HTML/test-build-apidocs`. This was the reason why building packages failed when testing with the `reprotest` tool. Because it is not possible to use the CMake project name in the admin module, the patch tries to get the correct name in the `.tdescminfo` file.
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

LGTM

LGTM
SlavekB merged commit 269bccc905 into master 3 years ago
SlavekB deleted branch fix/doxygen-module-name 3 years ago
SlavekB added this to the R14.0.10 release milestone 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as 269bccc905.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.10 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-common-admin#10
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/doxygen-module-name'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes