TDE

/

tde-common-admin

Update version detection for python 3. #15

Merged

SlavekB merged 1 commits from feat/update-to-python3 into master

MicheleC commented

Owner

As per title

MicheleC added this to the R14.1.0 release milestone

MicheleC added 1 commit

b9f28aa3c1

Update version detection for python 3.

Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>

MicheleC requested review from SlavekB

MicheleC referenced this pull request from TDE/tdebindings

Drop support for python2. #12

MicheleC added a new dependency

TDE/tdebindings#12 - Drop support for python2.

SlavekB added 1 commit

958058c582

Update version detection for python 3.

(alternative solution - intended for squash commits)

Signed-off-by: Slávek Banko <slavek.banko@axis.cz>

SlavekB commented

Owner

The solution used in the first commit was based on the original form of the code, but it looked less practical to maintain. That's why I made a proposal with an alternative solution in the second commit.

MicheleC commented

Poster

Owner

I like the solution in the second commit, definitely easier to maintain.

SlavekB force-pushed feat/update-to-python3 from 958058c582 to 7e4fd6fc51

SlavekB approved these changes

SlavekB left a comment

Owner

Tested together with tdebindings – it works as intended.

SlavekB merged commit 7e4fd6fc51 into master 1 year ago

SlavekB deleted branch feat/update-to-python3

Reviewers

SlavekB approved these changes

The pull request has been merged as 7e4fd6fc51.

Sign in to join this conversation.

No Assignees

2 Participants

Notifications

Due Date

No due date set.

TDE/tdebindings

Reference: TDE/tde-common-admin#15