Add support for autoconf + autoheader 2.7x #11

Merged
SlavekB merged 1 commits from feat/add-support-autoconf-2.7x into master 10 months ago
Owner

Successfully tested with tdewebdev and koffice on Debian SID + autoconf 2.70 from Experimental.

Successfully tested with tdewebdev and koffice on Debian SID + autoconf 2.70 from Experimental.
SlavekB added 1 commit 10 months ago
c23f9f6934
Add support for autoconf + autoheader 2.7x.
MicheleC approved these changes 10 months ago
MicheleC left a comment

Looks good but perhaps we can improve?

AUTOCONF_VERSION=`$AUTOCONF --version | head -n 1`
case $AUTOCONF_VERSION in
Autoconf*2.5* | autoconf*2.5* | autoconf*2.6* ) : ;;
Autoconf*2.5* | autoconf*2.[567]* ) : ;;
Poster
Owner

how about we use [5-9] so it will support already anything till 2.9 without requiring further changes? Hopefully we will be able to get rid of autotools before that, but just in case...

how about we use [5-9] so it will support already anything till 2.9 without requiring further changes? Hopefully we will be able to get rid of autotools before that, but just in case...
Poster
Owner

I gave 7 because here it is possible to test whether 2.70 seems to be compatible. Using 9 would mean that we hope not to make incompatible changes to autoconf.

In principle, we can do this because it shouldn't bring anything wrong:

  • autoconf will be compatible – no changes will be needed
  • autoconf violates compatibility – we would have to make adjustments anyway
  • we will get rid of the automake before there is 2.80 or 2.90.
I gave 7 because here it is possible to test whether 2.70 seems to be compatible. Using 9 would mean that we hope not to make incompatible changes to autoconf. In principle, we can do this because it shouldn't bring anything wrong: * autoconf will be compatible – no changes will be needed * autoconf violates compatibility – we would have to make adjustments anyway * we will get rid of the automake before there is 2.80 or 2.90.
Poster
Owner

we will get rid of the automake before there is 2.80 or 2.90.

I really hope so 😄

Btw there was a typo in my comment, I meant to write 2.99 and not 2.9. Anyway it's ok to merge as is for me.

> we will get rid of the automake before there is 2.80 or 2.90. I really hope so :smile: Btw there was a typo in my comment, I meant to write 2.99 and not 2.9. Anyway it's ok to merge as is for me.
Poster
Owner

I realized two more remarks:

  1. If 2.9x is followed by 2.10x, the test will not work again.
  2. 8 years have passed between version 2.69 and 2.70. If development continues to be similarly fast, there is high hope that we will have autoconf gone before autoconf 2.80.
I realized two more remarks: 1. If 2.9x is followed by 2.10x, the test will not work again. 2. 8 years have passed between version 2.69 and 2.70. If development continues to be similarly fast, there is high hope that we will have autoconf gone before autoconf 2.80.
Poster
Owner

👍

:+1:
MicheleC marked this conversation as resolved
SlavekB merged commit c23f9f6934 into master 10 months ago
SlavekB deleted branch feat/add-support-autoconf-2.7x 10 months ago
SlavekB added this to the R14.0.10 release milestone 10 months ago

Reviewers

MicheleC approved these changes 10 months ago
The pull request has been merged as c23f9f6934.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.