TDE
/
tde-common-admin
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Add support for autoconf + autoheader 2.7x #11

Merged
SlavekB merged 1 commits from feat/add-support-autoconf-2.7x into master 3 years ago
Conversation 0 Commits 1 Files Changed 1
SlavekB commented 3 years ago
Owner

Successfully tested with tdewebdev and koffice on Debian SID + autoconf 2.70 from Experimental.

Successfully tested with tdewebdev and koffice on Debian SID + autoconf 2.70 from Experimental.
SlavekB added 1 commit 3 years ago
c23f9f6934
Add support for autoconf + autoheader 2.7x.
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Looks good but perhaps we can improve?

Looks good but perhaps we can improve?
cvs.sh
AUTOCONF_VERSION=`$AUTOCONF --version | head -n 1`
case $AUTOCONF_VERSION in
Autoconf*2.5* | autoconf*2.5* | autoconf*2.6* ) : ;;
Autoconf*2.5* | autoconf*2.[567]* ) : ;;
MicheleC commented 3 years ago
Owner

how about we use [5-9] so it will support already anything till 2.9 without requiring further changes? Hopefully we will be able to get rid of autotools before that, but just in case...

how about we use [5-9] so it will support already anything till 2.9 without requiring further changes? Hopefully we will be able to get rid of autotools before that, but just in case...
SlavekB commented 3 years ago
Poster
Owner

I gave 7 because here it is possible to test whether 2.70 seems to be compatible. Using 9 would mean that we hope not to make incompatible changes to autoconf.

In principle, we can do this because it shouldn't bring anything wrong:

  • autoconf will be compatible – no changes will be needed
  • autoconf violates compatibility – we would have to make adjustments anyway
  • we will get rid of the automake before there is 2.80 or 2.90.
I gave 7 because here it is possible to test whether 2.70 seems to be compatible. Using 9 would mean that we hope not to make incompatible changes to autoconf. In principle, we can do this because it shouldn't bring anything wrong: * autoconf will be compatible – no changes will be needed * autoconf violates compatibility – we would have to make adjustments anyway * we will get rid of the automake before there is 2.80 or 2.90.
MicheleC commented 3 years ago
Owner

we will get rid of the automake before there is 2.80 or 2.90.

I really hope so 😄

Btw there was a typo in my comment, I meant to write 2.99 and not 2.9. Anyway it's ok to merge as is for me.

> we will get rid of the automake before there is 2.80 or 2.90. I really hope so :smile: Btw there was a typo in my comment, I meant to write 2.99 and not 2.9. Anyway it's ok to merge as is for me.
SlavekB commented 3 years ago
Poster
Owner

I realized two more remarks:

  1. If 2.9x is followed by 2.10x, the test will not work again.
  2. 8 years have passed between version 2.69 and 2.70. If development continues to be similarly fast, there is high hope that we will have autoconf gone before autoconf 2.80.
I realized two more remarks: 1. If 2.9x is followed by 2.10x, the test will not work again. 2. 8 years have passed between version 2.69 and 2.70. If development continues to be similarly fast, there is high hope that we will have autoconf gone before autoconf 2.80.
MicheleC commented 3 years ago
Owner

👍

:+1:
MicheleC marked this conversation as resolved
SlavekB merged commit c23f9f6934 into master 3 years ago
SlavekB deleted branch feat/add-support-autoconf-2.7x 3 years ago
SlavekB added this to the R14.0.10 release milestone 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as c23f9f6934.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.10 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-common-admin#11
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/add-support-autoconf-2.7x'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes