Allow TQt3 includes to exist somewhere other than /usr/include/tqt #7

Merged
SlavekB merged 1 commits from bug/cxxflags-overridden into master 1 year ago
aneejit1 commented 1 year ago
Collaborator

The test for TQt3 fails when it's not installed in /usr due to CXXFLAGS being hardcoded to /usr/include/tqt. Amended to append to CXXFLAGS.

Signed-off-by: aneejit1 aneejit1@gmail.com

The test for TQt3 fails when it's not installed in /usr due to CXXFLAGS being hardcoded to /usr/include/tqt. Amended to append to CXXFLAGS. Signed-off-by: aneejit1 <aneejit1@gmail.com>
Owner

Looks good to me. Since this is a common module, merge will probably be delayed till the next iteration 😄

Looks good to me. Since this is a common module, merge will probably be delayed till the next iteration :smile:
Owner

Here, it is worth considering whether to do a proper detection of libtqtinterface there and use the detected path instead of the fixed /usr/include/tqt.

Here, it is worth considering whether to do a proper detection of `libtqtinterface` there and use the detected path instead of the fixed `/usr/include/tqt`.
Owner

Here, it is worth considering whether to do a proper detection of libtqtinterface there and use the detected path instead of the fixed /usr/include/tqt.

It makes sense, but I think we can do that as a following step, unrelated to this PR.

> Here, it is worth considering whether to do a proper detection of `libtqtinterface` there and use the detected path instead of the fixed `/usr/include/tqt`. It makes sense, but I think we can do that as a following step, unrelated to this PR.
Owner

Here, it is worth considering whether to do a proper detection of libtqtinterface there and use the detected path instead of the fixed /usr/include/tqt.

It makes sense, but I think we can do that as a following step, unrelated to this PR.

In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the admin module to be useless asap…

> > Here, it is worth considering whether to do a proper detection of `libtqtinterface` there and use the detected path instead of the fixed `/usr/include/tqt`. > > It makes sense, but I think we can do that as a following step, unrelated to this PR. > > In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the `admin` module to be useless asap…
Owner

In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the admin module to be useless asap…

eh eh, you read my mind. IMO, we can just merge this PR and forget about it, since we are already planning to remove the admin module and we are slowly working on it already 😉

> In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the `admin` module to be useless asap… eh eh, you read my mind. IMO, we can just merge this PR and forget about it, since we are already planning to remove the admin module and we are slowly working on it already :wink:
SlavekB closed this pull request 1 year ago
SlavekB deleted branch bug/cxxflags-overridden 1 year ago
SlavekB added this to the R14.0.9 release milestone 1 year ago
The pull request has been merged as ae96f3ea48.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.