Labels Milestones

Allow TQt3 includes to exist somewhere other than /usr/include/tqt #7

Merged

SlavekB merged 1 commits from bug/cxxflags-overridden into master 1 year ago

Conversation 5 Commits 1 Files Changed 1

aneejit1 commented 1 year ago

Collaborator

The test for TQt3 fails when it's not installed in /usr due to CXXFLAGS being hardcoded to /usr/include/tqt. Amended to append to CXXFLAGS.

Signed-off-by: aneejit1 aneejit1@gmail.com

The test for TQt3 fails when it's not installed in /usr due to CXXFLAGS being hardcoded to /usr/include/tqt. Amended to append to CXXFLAGS. Signed-off-by: aneejit1 <aneejit1@gmail.com>

MicheleC commented 1 year ago

Owner

Looks good to me. Since this is a common module, merge will probably be delayed till the next iteration 😄

Looks good to me. Since this is a common module, merge will probably be delayed till the next iteration :smile:

SlavekB commented 1 year ago

Owner

Here, it is worth considering whether to do a proper detection of libtqtinterface there and use the detected path instead of the fixed /usr/include/tqt.

Here, it is worth considering whether to do a proper detection of `libtqtinterface` there and use the detected path instead of the fixed `/usr/include/tqt`.

MicheleC commented 1 year ago

Owner

Here, it is worth considering whether to do a proper detection of libtqtinterface there and use the detected path instead of the fixed /usr/include/tqt.

It makes sense, but I think we can do that as a following step, unrelated to this PR.

> Here, it is worth considering whether to do a proper detection of `libtqtinterface` there and use the detected path instead of the fixed `/usr/include/tqt`. It makes sense, but I think we can do that as a following step, unrelated to this PR.

SlavekB commented 1 year ago

Owner

Here, it is worth considering whether to do a proper detection of libtqtinterface there and use the detected path instead of the fixed /usr/include/tqt.

It makes sense, but I think we can do that as a following step, unrelated to this PR.

In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the admin module to be useless asap…

> > Here, it is worth considering whether to do a proper detection of `libtqtinterface` there and use the detected path instead of the fixed `/usr/include/tqt`. > > It makes sense, but I think we can do that as a following step, unrelated to this PR. > > In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the `admin` module to be useless asap…

MicheleC commented 1 year ago

Owner

In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the admin module to be useless asap…

eh eh, you read my mind. IMO, we can just merge this PR and forget about it, since we are already planning to remove the admin module and we are slowly working on it already 😉

> In addition, the question is whether to devote time to it or merge PR and leave it as it is, because we want the `admin` module to be useless asap… eh eh, you read my mind. IMO, we can just merge this PR and forget about it, since we are already planning to remove the admin module and we are slowly working on it already :wink:

SlavekB closed this pull request 1 year ago

SlavekB deleted branch bug/cxxflags-overridden 1 year ago

SlavekB added this to the R14.0.9 release milestone 1 year ago

The pull request has been merged as ae96f3ea48.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.9 release

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.