Implement tde_l10n_preparetips using the tde_l10n_prepare_xml #11

Merged
SlavekB merged 1 commits from feat/replace-preparetips-by-prepare-xml into master 5 years ago
Owner

The tips files have an XML-like structure. The large portion of the tde_l10n_preparetips macro code was similar to the code in tde_l10n_prepare_xml. And since the tde_l10n_prepare_xml macro has many options (including remove leading empty lines), it could be used to prepare tips.

Note0: For this PR, it is required that #9 be already merged.

Note1: Tested with tips in tdebase: kate, ktip and konsole, and knowit application.

Note2: Here, it might make sense to mark translations as no-c-format, but the original prepartips script did not do this. That's why I kept it the same.

The `tips` files have an XML-like structure. The large portion of the tde_l10n_preparetips macro code was similar to the code in tde_l10n_prepare_xml. And since the tde_l10n_prepare_xml macro has many options (including remove leading empty lines), it could be used to prepare tips. Note0: For this PR, it is required that #9 be already merged. Note1: Tested with tips in tdebase: kate, ktip and konsole, and knowit application. Note2: Here, it might make sense to mark translations as `no-c-format`, but the original prepartips script did not do this. That's why I kept it the same.
MicheleC approved these changes 5 years ago
MicheleC left a comment
Owner

Looks ok

Looks ok
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/replace-preparetips-by-prepare-xml 5 years ago
SlavekB added this to the R14.0.6 release milestone 5 years ago
The pull request has been merged as 72ca5313ec.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-cmake#11
Loading…
There is no content yet.