Set the LINK_INTERFACE_LIBRARIES and INTERFACE_LINK_LIBRARIES #54
Merged
SlavekB
merged 1 commits from fix/link-private-ftbfs into master 4 years ago
No reviewers
No Label
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TDE/tde-cmake#54
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'fix/link-private-ftbfs'
Deleting a branch is permanent. It CANNOT be undone. Continue?
This resolve FTBFS when using private linking if the build is
of type Debug. This is the case I use on my FreeBSD test machine.
perhaps there is room for improving the code?
set_target_properties( ${_target} PROPERTIESLINK_INTERFACE_LIBRARIES "${_shared_libs}"INTERFACE_LINK_LIBRARIES "${_shared_libs}" )string( TOUPPER ${CMAKE_BUILD_TYPE} _build_type )Why don't do this before line 1075 and then have a single call to "set_target_properties" instead of calling it twice? Am I missing something?
Yes, good point, I'll combine it into one call and test.
LGTM now
e769cc0003.